Don't show favicons or throbbers for the New Tab page on the Mac....

Don't show favicons or throbbers for the New Tab page on the Mac.

This change nets another 35ms (15%) improvement in the duration between the
renderer requesting the NTP and it having all of the resources for the NTP
available and being completely done with layout on my Mac laptop in release
mode.

For any page which DOMUI indicates no icon should be shown, including the New
Tab page, don't show a favicon or throbber.  When the icon is removed, the
title should expand to the left to fill the void.  Compare to the behavior on
Windows and Linux.

http://groups.google.com/group/chromium-dev/browse_thread/thread/7148074f807dc5f7

BUG=13337
20378
TEST=No throbber or favicon on the New Tab page

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25167

[Mark Mentovai, 2009-09-02 05:26:02]

There were some bugs in the first version, so I fixed them.

The nib change just turns on tail truncation for the title text in the tab.  We
were getting tail truncation before, but it wasn't set in the nib.

[pink (ping after 24hrs), 2009-09-02 13:47:07]

LGTM, however with the nib change, Cole sent me some files to do a fade via the
cell rather than end truncation. That was his plan all along, i guess they just
missed the last train.

http://codereview.chromium.org/184003/diff/4001/5003
File chrome/browser/cocoa/tab_controller.mm (right):

http://codereview.chromium.org/184003/diff/4001/5003#newcode173
Line 173: BOOL oldShowIcon = isIconShowing_ ? YES : NO;
can't we use the current isHidden state? Do we have to have a member?

http://codereview.chromium.org/184003/diff/4001/5005
File chrome/browser/cocoa/tab_controller_unittest.mm (right):

http://codereview.chromium.org/184003/diff/4001/5005#newcode256
Line 256: EXPECT_TRUE([controller shouldShowCloseButton]);
add a TODO to write a test that has the icon view hidden?

[Mark Mentovai, 2009-09-02 15:00:21]

pinkerton@chromium.org wrote:
> LGTM, however with the nib change, Cole sent me some files to do a fade
> via the cell rather than end truncation. That was his plan all along, i
> guess they just missed the last train.

Do you want me to drop the nib from this then?  Is there a bug for the fade?

> http://codereview.chromium.org/184003/diff/4001/5003#newcode173
> Line 173: BOOL oldShowIcon = isIconShowing_ ? YES : NO;
> can't we use the current isHidden state? Do we have to have a member?

We can't use isHidden for a reason that's completely not obvious.
iconView_ gets replaced a lot, including being replaced with nil.
I've added a comment.

> http://codereview.chromium.org/184003/diff/4001/5005#newcode256
> Line 256: EXPECT_TRUE([controller shouldShowCloseButton]);
> add a TODO to write a test that has the icon view hidden?

We alrady test that it hides - do you mean to do something like asking
the controller for the actual live views, since they can be swapped?

Mark