Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1840013002: Move most_visited_sites* files to the ntp directory in c/b/a/ (Closed)

Created:
4 years, 8 months ago by markusheintz_
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Marc Treib, May
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move most_visited_sites* files to the ntp directory in c/b/a/ BUG=596080 Committed: https://crrev.com/2447cc1b134f127a6f1d956b2d30585b53c58a89 Cr-Commit-Position: refs/heads/master@{#383715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1365 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/android/most_visited_sites.h View 1 chunk +0 lines, -246 lines 0 comments Download
D chrome/browser/android/most_visited_sites.cc View 1 chunk +0 lines, -868 lines 0 comments Download
D chrome/browser/android/most_visited_sites_unittest.cc View 1 chunk +0 lines, -239 lines 0 comments Download
A + chrome/browser/android/ntp/most_visited_sites.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/ntp/most_visited_sites.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/android/ntp/most_visited_sites_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
markusheintz_
On 2016/03/29 12:59:27, markusheintz_ wrote: > mailto:markusheintz@chromium.org changed reviewers: > + mailto:bauerb@chromium.org PTAL Thanks!
4 years, 8 months ago (2016-03-29 12:59:39 UTC) #3
Marc Treib
lgtm
4 years, 8 months ago (2016-03-29 13:05:50 UTC) #5
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-03-29 13:07:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840013002/1
4 years, 8 months ago (2016-03-29 13:09:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 13:52:37 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 13:54:47 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2447cc1b134f127a6f1d956b2d30585b53c58a89
Cr-Commit-Position: refs/heads/master@{#383715}

Powered by Google App Engine
This is Rietveld 408576698