Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1839993002: [heap] Fix scavenger --trace-gc-nvp glitches. (Closed)

Created:
4 years, 8 months ago by Hannes Payer (out of office)
Modified:
4 years, 8 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix scavenger --trace-gc-nvp glitches. BUG= Committed: https://crrev.com/efc4ab58e7e06d19b916d6057bf4060a9433fda1 Cr-Commit-Position: refs/heads/master@{#35100}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M src/heap/gc-tracer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 7 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Hannes Payer (out of office)
4 years, 8 months ago (2016-03-29 11:23:20 UTC) #2
ulan
I am working in the same area: 1830723004 :)
4 years, 8 months ago (2016-03-29 11:25:17 UTC) #4
ulan
lgtm
4 years, 8 months ago (2016-03-29 11:39:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839993002/20001
4 years, 8 months ago (2016-03-29 11:40:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 12:02:52 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 12:04:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efc4ab58e7e06d19b916d6057bf4060a9433fda1
Cr-Commit-Position: refs/heads/master@{#35100}

Powered by Google App Engine
This is Rietveld 408576698