Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1991)

Issue 1839983002: [api] Restrict Template::Set to take templates or primitive values (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Restrict Template::Set to take templates or primitive values Embedders that passed in non-primitive values should either use getters/setters (templates) or install a native data property, otherwise, the values would all result in cross-context leaks BUG=none R=verwaest@chromium.org LOG=y Committed: https://crrev.com/eebdee8eafa97849cc70c25f3fecf1b075bac248 Cr-Commit-Position: refs/heads/master@{#35244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M include/v8.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-03-29 11:04:16 UTC) #1
Toon Verwaest
lgtm
4 years, 8 months ago (2016-03-29 20:19:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839983002/1
4 years, 8 months ago (2016-04-04 15:29:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 16:58:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eebdee8eafa97849cc70c25f3fecf1b075bac248 Cr-Commit-Position: refs/heads/master@{#35244}
4 years, 8 months ago (2016-04-04 16:58:50 UTC) #7
jochen (gone - plz use gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1859993002/ by jochen@chromium.org. ...
4 years, 8 months ago (2016-04-05 14:13:34 UTC) #8
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-04-05 14:13:37 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1860003002/ by jochen@chromium.org.

The reason for reverting is: Breaks node.js.

Powered by Google App Engine
This is Rietveld 408576698