If the <use> is hidden and the child of it is visible, should clip the non-resource

third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
index 01734e2a85d7ed7c39ebf1c170a2c1dcbaf86fc0..2bc1b5763ae677146a101c4f9cc7eb364dbc9144 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
@@ -86,7 +86,7 @@ bool LayoutSVGResourceClipper::calculateClipContentPathIfNeeded()
             continue;
 
         const ComputedStyle* style = childLayoutObject->style();
-        if (!style || style->display() == NONE || style->visibility() != VISIBLE)
+        if (!style || style->display() == NONE)

[fs, 2016/04/19 10:17:27]

I went looking through the various specs (CSS Masking [1], SVG 1.1 2ed [2]), and
they all said:

"If a child element is made invisible by display or visibility it does not
contribute to the clipping path."

So now I'm a little bit confused as to what the current state of affairs is
here... So I went digging and found [3] - and nothing changing that behavior
again. So I think the behavior should not change (except for <use> of course.)

(If you want to reference anything here, then [1] might be the most relevant -
more so than the <use> element reference.)

[1] https://drafts.fxtf.org/css-masking-1/#ClipPathElement
[2] https://www.w3.org/TR/SVG/masking.html#EstablishingANewClippingPath
[3] https://www.w3.org/2009/07/01-svg-minutes.html#item02

[hyunjunekim2, 2016/04/27 12:18:40]

So Just check child of <use> element whether visible or not.

             continue;
 
         // Current shape in clip-path gets clipped too. Fallback to masking.
@@ -221,8 +221,12 @@ void LayoutSVGResourceClipper::calculateClipContentPaintInvalidationRect()
         if (!layoutObject->isSVGShape() && !layoutObject->isSVGText() && !isSVGUseElement(*childElement))
             continue;
         const ComputedStyle* style = layoutObject->style();
-        if (!style || style->display() == NONE || style->visibility() != VISIBLE)
+        if (!style || style->display() == NONE)

[fs, 2016/04/19 10:17:27]

Same comment here as in calculateClipContentPathIfNeeded().

[hyunjunekim2, 2016/04/27 12:18:40]

Done.

             continue;
+
+        if (isSVGUseElement(*childElement) && !toSVGUseElement(*childElement).isVisibleGraphicsElementForClipping())
+            continue;
+
         m_clipBoundaries.unite(layoutObject->localToSVGParentTransform().mapRect(layoutObject->paintInvalidationRectInLocalSVGCoordinates()));
     }
     m_clipBoundaries = toSVGClipPathElement(element())->calculateAnimatedLocalTransform().mapRect(m_clipBoundaries);