third_party/WebKit/LayoutTests/svg/clip-path/nested-clip-path-as-use-element.html - Issue 1839973003: If the <use> is hidden and the child of it is visible, should clip the non-resource

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/clip-path/nested-clip-path-as-use-element.html

Issue 1839973003: If the <use> is hidden and the child of it is visible, should clip the non-resource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/svg/clip-path/invisible-clip-path-as-use-element-expected.html ('K') | « third_party/WebKit/LayoutTests/svg/clip-path/invisible-clip-path-as-use-element-expected.html ('k') | third_party/WebKit/LayoutTests/svg/clip-path/nested-clip-path-as-use-element-expected.html » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>
	fs 2016/04/27 14:14:39 You should probably include "hidden" and/or "visib You should probably include "hidden" and/or "visibility" in the filename. hyunjunekim2 2016/04/29 12:59:09 Done. Changed file name. Done. Changed file name.
	2 <svg>

	3 <defs visibility="hidden">
	fs 2016/04/27 14:14:39 To avoid all the visibility=... you could have two To avoid all the visibility=... you could have two <defs> - one with visibility=hidden and one "plain" (and hence with visibility=visible since it's the default.) Or just remove all the visiblity=... except the one on the <use>. hyunjunekim2 2016/04/29 12:59:09 Done. Show quoted text On 2016/04/27 14:14:39, fs wrote: > To avoid all the visibility=... you could have two <defs> - one with > visibility=hidden and one "plain" (and hence with visibility=visible since it's > the default.) Or just remove all the visiblity=... except the one on the <use>. Done.
	4 <rect id="rect" x="0" y="0" width="100" height="100" visibility="visible "></rect>
	fs 2016/04/27 14:14:39 x="0" y="0" is the default, so drop. x="0" y="0" is the default, so drop. hyunjunekim2 2016/04/29 12:59:09 Done. Show quoted text On 2016/04/27 14:14:39, fs wrote: > x="0" y="0" is the default, so drop. Done.
	5 <clipPath id="clipClip1">

	6 <rect x="0" y="0" width="100" height="100" visibility="visible"/>
	fs 2016/04/27 14:14:39 Ditto. Ditto. hyunjunekim2 2016/04/29 12:59:09 Done. Show quoted text On 2016/04/27 14:14:39, fs wrote: > Ditto. Done.
	7 </clipPath>

	8 <clipPath id="clip0" clip-path="url(#clipClip1)">

	9 <use visibility="hidden" xlink:href="#rect"/>

	10 </clipPath>

	11 </defs>

	12 <rect y="0" x="0" height="100" width="100" fill="green" clip-path="url(#clip 0)"/>
	fs 2016/04/27 14:14:39 Ditto. Also, make this <rect> larger than the cli Ditto. Also, make this <rect> larger than the clip. hyunjunekim2 2016/04/29 12:59:09 Done. Show quoted text On 2016/04/27 14:14:39, fs wrote: > Ditto. > > Also, make this <rect> larger than the clip. Done.
	13 </svg>

OLD	NEW