third_party/WebKit/LayoutTests/svg/clip-path/invisible-clip-path-as-geometry-element.html - Issue 1839973003: If the <use> is hidden and the child of it is visible, should clip the non-resource

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/clip-path/invisible-clip-path-as-geometry-element.html

Issue 1839973003: If the <use> is hidden and the child of it is visible, should clip the non-resource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/clip-path/invisible-clip-path-as-geometry-element-expected.html » ('j') | third_party/WebKit/LayoutTests/svg/clip-path/invisible-clip-path-as-geometry-element-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <div style="visibility: hidden;">
	fs 2016/04/19 10:17:27 Having this <div> wrapper doesn't seem relevant fo Having this <div> wrapper doesn't seem relevant for this test. You could as well specify visibility on the <svg> or the <defs>. (The visibility on the clipped <rect> isn't relevant to this test either, because if it was 'hidden', that <rect> would not be rendered.) hyunjunekim2 2016/04/27 12:18:39 Done. Show quoted text On 2016/04/19 10:17:27, fs wrote: > Having this <div> wrapper doesn't seem relevant for this test. You could as well > specify visibility on the <svg> or the <defs>. (The visibility on the clipped > <rect> isn't relevant to this test either, because if it was 'hidden', that > <rect> would not be rendered.) Done.
	3 <svg>

	4 <defs>

	5 <clipPath id="clip">

	6 <rect x="0" y="0" width="400" height="300"></rect>
	fs 2016/04/19 10:17:27 I would have the geometries in this test be so tha I would have the geometries in this test be so that it would be obvious if the clip is applied or not (as compared being considered empty for example.) So: <rect width="100" height="100"/> here and <rect width="200" height="200" .../> below (Per above this test is invalid though.) hyunjunekim2 2016/04/27 12:18:39 Remove this test. Remove this test.
	7 </clipPath>

	8 </defs>

	9 <rect x="0" y="0" width="100" height="100" fill="green" visibility="visible" clip-path="url(#clip)"></rect>

	10 </svg>

	11 </div>

OLD	NEW