Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1839963003: Fix crash in speech_recognizer service (Closed)

Created:
4 years, 8 months ago by armansito1
Modified:
4 years, 8 months ago
Reviewers:
thatguy, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix crash in speech_recognizer service There is a race condition between messages received from mojo and speech recognition events received from the system, which can cause a NullPointerException. This patch fixes that. R=qsr@chromium.org, thatguy@google.com, qsr@google.com BUG= Committed: https://chromium.googlesource.com/external/mojo/+/b08b56a4b162493f497182950f2051f478093318

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
armansito1
PTAL
4 years, 8 months ago (2016-03-30 04:02:36 UTC) #1
qsr
lgtm
4 years, 8 months ago (2016-03-30 09:39:56 UTC) #4
thatguy
lgtm
4 years, 8 months ago (2016-03-30 17:27:09 UTC) #5
armansito1
4 years, 8 months ago (2016-03-30 17:29:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b08b56a4b162493f497182950f2051f478093318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698