Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: ui/file_manager/video_player/js/video_player.js

Issue 1839953002: Video Player: Call video element's load method on loading video file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/video_player/js/video_player.js
diff --git a/ui/file_manager/video_player/js/video_player.js b/ui/file_manager/video_player/js/video_player.js
index 4b9837698ec249a23c7382c277692e62bcd13da3..1d0b23d82dfd42221a77c6ccf2b0dec0b2503e85 100644
--- a/ui/file_manager/video_player/js/video_player.js
+++ b/ui/file_manager/video_player/js/video_player.js
@@ -423,16 +423,7 @@ VideoPlayer.prototype.loadVideo_ = function(video, opt_callback) {
this.updateInactivityWatcherState_();
}.wrap(this));
this.controls.attachMedia(this.videoElement_);
- // TODO(ryoh):
- // If you modify the video element that is already inserted,
- // you have to call load() method.
- // https://dev.w3.org/html5/spec-author-view/video.html
- // But we always create new video element (see above),
- // we don't have to call load().
- // If you call load() method here,
- // you can't see subtitles.
- // (It might be a bug: https://crbug.com/594537)
- //this.videoElement_.load();
+ this.videoElement_.load();
callback();
}.bind(this))
// In case of error.

Powered by Google App Engine
This is Rietveld 408576698