Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: content/renderer/pepper/plugin_object.cc

Issue 1839933002: Ensure we don't leak ObjectProxy objects Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/proxy/ppp_class_proxy.cc » ('j') | ppapi/proxy/ppp_class_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/plugin_object.cc
diff --git a/content/renderer/pepper/plugin_object.cc b/content/renderer/pepper/plugin_object.cc
index cb5ff6af9bbd924ae918b87e196c2b130afb5cc6..3d122318ec9b594138b9c38dc95eeb6335f1b2ad 100644
--- a/content/renderer/pepper/plugin_object.cc
+++ b/content/renderer/pepper/plugin_object.cc
@@ -49,10 +49,9 @@ const char kInvalidValueException[] = "Error: Invalid value";
// PluginObject ----------------------------------------------------------------
PluginObject::~PluginObject() {
- if (instance_) {
- ppp_class_->Deallocate(ppp_class_data_);
+ ppp_class_->Deallocate(ppp_class_data_);
piman 2016/03/29 18:28:51 So, in theory, we are not supposed to call back in
+ if (instance_)
instance_->RemovePluginObject(this);
- }
}
// static
« no previous file with comments | « no previous file | ppapi/proxy/ppp_class_proxy.cc » ('j') | ppapi/proxy/ppp_class_proxy.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698