Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 1839923002: Add tests for IME menu private APIs. (Closed)

Created:
4 years, 8 months ago by Azure Wei
Modified:
4 years, 8 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for IME menu private APIs. --testActivateAndListChange: for inputMethodPrivate.onImeMenuListChanged --testSetAndUpdateMenuItems: for inputMethodPrivate.onImeMenuItemsChanged --testNotifyMenuItems: for inputMethodPrivate.notifyImeMenuItemActivated BUG=570761 TEST=ExtensionInputMethodApiTest.ImeMenuAPITest Committed: https://crrev.com/f16fa0a4e48adbb4deced75a6b7c3474b909d2df Cr-Commit-Position: refs/heads/master@{#383911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -1 line) Patch
M chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc View 3 chunks +39 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/input_method/ime_menu2/background.js View 1 chunk +123 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/input_method/ime_menu2/manifest.json View 1 chunk +19 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Azure Wei
Hello Shu, please review this cl. Thanks you!
4 years, 8 months ago (2016-03-29 05:15:22 UTC) #3
Shu Chen
lgtm
4 years, 8 months ago (2016-03-30 03:50:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839923002/1
4 years, 8 months ago (2016-03-30 03:55:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 05:08:44 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 05:11:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f16fa0a4e48adbb4deced75a6b7c3474b909d2df
Cr-Commit-Position: refs/heads/master@{#383911}

Powered by Google App Engine
This is Rietveld 408576698