Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp

Issue 1839913002: Implement PaintWorkletGlobalScope#registerPaint() for the CSS Paint API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp
diff --git a/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp b/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp
index 3e1165655c4a636622b66e7c3952f77dc46e42fd..c854bfb2df5e953d7b6281ac2eeb9402ec976d57 100644
--- a/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp
+++ b/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp
@@ -4,6 +4,7 @@
#include "modules/csspaint/WindowPaintWorklet.h"
+#include "bindings/core/v8/WorkerOrWorkletScriptController.h"
#include "core/frame/LocalDOMWindow.h"
#include "core/frame/LocalFrame.h"
#include "modules/csspaint/PaintWorklet.h"
@@ -46,6 +47,13 @@ PaintWorklet* WindowPaintWorklet::paintWorklet(ExecutionContext* executionContex
return m_paintWorklet.get();
}
+void WindowPaintWorklet::willDetachGlobalObjectFromFrame()
ikilpatrick 2016/03/30 19:12:50 I'm not sure if the dispose call on the scriptCont
+{
+ if (m_paintWorklet)
+ m_paintWorklet->workletGlobalScope()->scriptController()->dispose();
+ DOMWindowProperty::willDetachGlobalObjectFromFrame();
+}
+
DEFINE_TRACE(WindowPaintWorklet)
{
visitor->trace(m_paintWorklet);

Powered by Google App Engine
This is Rietveld 408576698