third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp - Issue 1839913002: Implement PaintWorkletGlobalScope#registerPaint() for the CSS Paint API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp

Issue 1839913002: Implement PaintWorkletGlobalScope#registerPaint() for the CSS Paint API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp ('K') | « third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.h ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp

diff --git a/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp b/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp

index 3e1165655c4a636622b66e7c3952f77dc46e42fd..c854bfb2df5e953d7b6281ac2eeb9402ec976d57 100644

--- a/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp

+++ b/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp

@@ -4,6 +4,7 @@

#include "modules/csspaint/WindowPaintWorklet.h"

+#include "bindings/core/v8/WorkerOrWorkletScriptController.h"

#include "core/frame/LocalDOMWindow.h"

#include "core/frame/LocalFrame.h"

#include "modules/csspaint/PaintWorklet.h"

@@ -46,6 +47,13 @@ PaintWorklet* WindowPaintWorklet::paintWorklet(ExecutionContext* executionContex

return m_paintWorklet.get();

}

+void WindowPaintWorklet::willDetachGlobalObjectFromFrame()

+ if (m_paintWorklet)

+ m_paintWorklet->workletGlobalScope()->scriptController()->dispose();

+ DOMWindowProperty::willDetachGlobalObjectFromFrame();

DEFINE_TRACE(WindowPaintWorklet)

{

visitor->trace(m_paintWorklet);