chrome/browser/extensions/extension_service.cc - Issue 18399007: Don't count host permission changes for v2 apps as a permission increase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 18399007: Don't count host permission changes for v2 apps as a permission increase. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: refactor Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index a6851a7dc4d766bf47a088181ede33b62e4e59d3..3702aa3905ea4178f7668e1d783c7efec1bccd0f 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -2153,7 +2153,7 @@ void ExtensionService::CheckPermissionsIncrease(const Extension* extension,

// upgraded and recognized additional privileges, or an extension upgrades

// to a version that requires additional privileges.

is_privilege_increase = granted_permissions->HasLessPrivilegesThan(

- extension->GetActivePermissions().get());

+ extension->GetActivePermissions().get(), extension->GetType());

}

if (is_extension_upgrade) {

« no previous file with comments | « no previous file | chrome/common/extensions/permissions/permission_set.h » ('j') | chrome/common/extensions/permissions/permission_set.h » ('J')