src/frames.cc - Issue 1839843002: wasm: implemente WasmFrame::cast, fix inheritance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 1839843002: wasm: implemente WasmFrame::cast, fix inheritance (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix inheritance Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index cfacbac45922f547258b75a11f179828aa4b96f3..5a1c33419fac901ce8d3a5424be68f6ef99a0e7e 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -766,7 +766,7 @@ void StandardFrame::IterateCompiledFrame(ObjectVisitor* v) const {

// Visit the return address in the callee and incoming arguments.

IteratePc(v, pc_address(), constant_pool_address(), code);

- if (!is_wasm() && !is_wasm_to_js()) {

+ if (!is_wasm() || is_wasm_to_js()) {

bradnelson 2016/03/29 17:06:57 don't do that...

JF 2016/03/29 17:08:17 Thought I'd backed that off.

// Visit the context in stub frame and JavaScript frame.

// Visit the function in JavaScript frame.

v->VisitPointers(frame_header_base, frame_header_limit);

« no previous file with comments | « src/frames.h ('k') | src/frames-inl.h » ('j') | no next file with comments »