Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1839833002: Add histogram entry for GpuVideoDecoder errors. (Closed)

Created:
4 years, 8 months ago by DaleCurtis
Modified:
4 years, 8 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histogram entry for GpuVideoDecoder errors. Not sure how we missed having these logged... Adding this also required fixing the UMA enum name to match the media/ PRESUBMIT style: must end with _MAX and that value must be equal to the last enum value. BUG=598456 TEST=errors show up in chrome://histograms/Media.GpuVideoDecoderError. Committed: https://crrev.com/64739369777e41880b12fbbeb6ad2ddd31f40053 Cr-Commit-Position: refs/heads/master@{#383640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/ppb_video_decoder_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M media/video/video_decode_accelerator.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +23 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
DaleCurtis
holte@ for UMA changes, bbudge@ for trivial content/renderer/pepper changes.
4 years, 8 months ago (2016-03-28 22:48:00 UTC) #2
DaleCurtis
+sandersd@ for media/ review
4 years, 8 months ago (2016-03-28 22:49:12 UTC) #4
Steven Holte
lgtm
4 years, 8 months ago (2016-03-28 23:02:51 UTC) #5
sandersd (OOO until July 31)
lgtm
4 years, 8 months ago (2016-03-28 23:09:27 UTC) #6
bbudge
content/renderer/pepper LGTM
4 years, 8 months ago (2016-03-28 23:10:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839833002/1
4 years, 8 months ago (2016-03-28 23:25:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 00:55:46 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 00:57:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64739369777e41880b12fbbeb6ad2ddd31f40053
Cr-Commit-Position: refs/heads/master@{#383640}

Powered by Google App Engine
This is Rietveld 408576698