Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1839813003: [Contextual Search] Fixes Promo position after rotation. (Closed)

Created:
4 years, 8 months ago by pedro (no code reviews)
Modified:
4 years, 8 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Fixes Promo position after rotation. BUG=598506 Committed: https://crrev.com/6ff7e4a57248d0e9629da0d7df318a40b7bf7565 Cr-Commit-Position: refs/heads/master@{#383814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pedro (no code reviews)
Theresa, please take a look at this change.
4 years, 8 months ago (2016-03-29 01:36:53 UTC) #3
Theresa
lgtm
4 years, 8 months ago (2016-03-29 20:26:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839813003/1
4 years, 8 months ago (2016-03-29 20:42:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 20:50:09 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 20:51:52 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ff7e4a57248d0e9629da0d7df318a40b7bf7565
Cr-Commit-Position: refs/heads/master@{#383814}

Powered by Google App Engine
This is Rietveld 408576698