Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 1839803007: Guard Element and getComputedStyle methods that force a layout with inActiveDocument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 6 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 styledNode = this->styledNode(); 559 styledNode = this->styledNode();
560 layoutObject = styledNode->layoutObject(); 560 layoutObject = styledNode->layoutObject();
561 561
562 style = computeComputedStyle(); 562 style = computeComputedStyle();
563 563
564 bool forceFullLayout = isLayoutDependent(propertyID, style, layoutObject) 564 bool forceFullLayout = isLayoutDependent(propertyID, style, layoutObject)
565 || styledNode->isInShadowTree() 565 || styledNode->isInShadowTree()
566 || (document.ownerElement() && document.ensureStyleResolver().hasViewpor tDependentMediaQueries()); 566 || (document.ownerElement() && document.ensureStyleResolver().hasViewpor tDependentMediaQueries());
567 567
568 if (forceFullLayout) { 568 if (forceFullLayout) {
569 document.updateLayoutIgnorePendingStylesheets(); 569 document.updateLayoutIgnorePendingStylesheetsForNode(styledNode);
570 styledNode = this->styledNode(); 570 styledNode = this->styledNode();
ojan 2016/03/30 01:10:47 Not relevant to this patch, but this line could us
571 style = computeComputedStyle(); 571 style = computeComputedStyle();
572 layoutObject = styledNode->layoutObject(); 572 layoutObject = styledNode->layoutObject();
573 } 573 }
574 574
575 if (!style) 575 if (!style)
576 return nullptr; 576 return nullptr;
577 577
578 RefPtrWillBeRawPtr<CSSValue> value = ComputedStyleCSSValueMapping::get(prope rtyID, *style, layoutObject, styledNode, m_allowVisitedStyle); 578 RefPtrWillBeRawPtr<CSSValue> value = ComputedStyleCSSValueMapping::get(prope rtyID, *style, layoutObject, styledNode, m_allowVisitedStyle);
579 if (value) 579 if (value)
580 return value; 580 return value;
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 exceptionState.throwDOMException(NoModificationAllowedError, "These styles a re computed, and therefore the '" + getPropertyNameString(id) + "' property is r ead-only."); 703 exceptionState.throwDOMException(NoModificationAllowedError, "These styles a re computed, and therefore the '" + getPropertyNameString(id) + "' property is r ead-only.");
704 } 704 }
705 705
706 DEFINE_TRACE(CSSComputedStyleDeclaration) 706 DEFINE_TRACE(CSSComputedStyleDeclaration)
707 { 707 {
708 visitor->trace(m_node); 708 visitor->trace(m_node);
709 CSSStyleDeclaration::trace(visitor); 709 CSSStyleDeclaration::trace(visitor);
710 } 710 }
711 711
712 } // namespace blink 712 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698