Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: url/url.gyp

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « url/features.gni ('k') | url/url_canon_icu_alternatives_ios.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/url.gyp
diff --git a/url/url.gyp b/url/url.gyp
index 9ab87e1a5782420249e085d0bd6fea5001555276..a1670725f163918dbb0e1f4101dd21a50d846366 100644
--- a/url/url.gyp
+++ b/url/url.gyp
@@ -19,8 +19,7 @@
'dependencies': [
'../base/base.gyp:base',
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
- '../third_party/icu/icu.gyp:icui18n',
- '../third_party/icu/icu.gyp:icuuc',
+ ':url_url_features',
],
'sources': [
'<@(gurl_sources)',
@@ -35,6 +34,40 @@
],
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [4267, ],
+
+ # ICU Alternatives for Android & iOS
+ 'conditions': [
+ ['use_platform_icu_alternatives == 1', {
+ 'sources!': [
+ 'url_canon_icu.cc',
+ 'url_canon_icu.h',
+ ],
+ 'conditions': [
+ ['OS == "android"', {
+ 'dependencies': [
+ 'url_java',
+ 'url_jni_headers',
+ ],
+ 'sources': [
+ 'url_canon_icu_alternatives_android.cc',
+ 'url_canon_icu_alternatives_android.h',
+ ],
+ }],
+ ['OS == "ios"', {
+ 'sources': [
+ 'url_canon_icu_alternatives_ios.mm',
+ ],
+ }],
+ ],
+ },
+ # 'use_platform_icu_alternatives != 1'
+ {
+ 'dependencies': [
+ '../third_party/icu/icu.gyp:icui18n',
+ '../third_party/icu/icu.gyp:icuuc',
+ ],
+ }],
+ ],
},
{
'target_name': 'url_unittests',
@@ -64,6 +97,21 @@
'mojo/url_gurl_struct_traits_unittest.cc',
],
}],
+ # Unit tests that are not supported by the current ICU alternatives on Android.
+ ['OS == "android" and use_platform_icu_alternatives == 1', {
+ 'sources!': [
+ 'url_canon_icu_unittest.cc',
+ ],
+ }],
+ # Unit tests that are not supported by the current ICU alternatives on iOS.
+ ['OS == "ios" and use_platform_icu_alternatives == 1', {
+ 'sources!': [
+ 'origin_unittest.cc',
+ 'scheme_host_port_unittest.cc',
+ 'url_canon_icu_unittest.cc',
+ 'url_canon_unittest.cc',
+ ],
+ }],
],
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [4267, ],
@@ -124,6 +172,17 @@
'url_test_interfaces_mojom',
],
},
+ {
+ # GN version: //url:url_features
+ 'target_name': 'url_url_features',
+ 'includes': [ '../build/buildflag_header.gypi' ],
+ 'variables': {
+ 'buildflag_header_path': 'url/url_features.h',
+ 'buildflag_flags': [
+ 'USE_PLATFORM_ICU_ALTERNATIVES=<(use_platform_icu_alternatives)',
+ ],
+ },
+ }
],
'conditions': [
['OS=="android"', {
@@ -150,35 +209,6 @@
],
'includes': [ '../build/java.gypi' ],
},
- {
- # Same as url_lib but using ICU alternatives on Android.
- 'target_name': 'url_lib_use_icu_alternatives_on_android',
- 'type': '<(component)',
- 'dependencies': [
- '../base/base.gyp:base',
- '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
- 'url_java',
- 'url_jni_headers',
- ],
- 'sources': [
- '<@(gurl_sources)',
- 'url_canon_icu_alternatives_android.cc',
- 'url_canon_icu_alternatives_android.h',
- ],
- 'sources!': [
- 'url_canon_icu.cc',
- 'url_canon_icu.h',
- ],
- 'direct_dependent_settings': {
- 'include_dirs': [
- '..',
- ],
- },
- 'defines': [
- 'URL_IMPLEMENTATION',
- 'USE_ICU_ALTERNATIVES_ON_ANDROID=1',
- ],
- },
],
}],
['test_isolation_mode != "noop"', {
« no previous file with comments | « url/features.gni ('k') | url/url_canon_icu_alternatives_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698