| Index: url/BUILD.gn
|
| diff --git a/url/BUILD.gn b/url/BUILD.gn
|
| index 361c516fd28584324eb085477122423c0db687df..6172f9450048e1b6b45db83a469c098c371ffb80 100644
|
| --- a/url/BUILD.gn
|
| +++ b/url/BUILD.gn
|
| @@ -3,59 +3,50 @@
|
| # found in the LICENSE file.
|
|
|
| import("//testing/test.gni")
|
| +import("features.gni")
|
|
|
| if (is_android) {
|
| import("//build/config/android/rules.gni")
|
| }
|
|
|
| -# Shared sources between url and url_lib_use_icu_alternatives_on_android.
|
| -url_shared_sources = [
|
| - "gurl.cc",
|
| - "gurl.h",
|
| - "origin.cc",
|
| - "origin.h",
|
| - "scheme_host_port.cc",
|
| - "scheme_host_port.h",
|
| - "third_party/mozilla/url_parse.cc",
|
| - "third_party/mozilla/url_parse.h",
|
| - "url_canon.h",
|
| - "url_canon_etc.cc",
|
| - "url_canon_filesystemurl.cc",
|
| - "url_canon_fileurl.cc",
|
| - "url_canon_host.cc",
|
| - "url_canon_internal.cc",
|
| - "url_canon_internal.h",
|
| - "url_canon_internal_file.h",
|
| - "url_canon_ip.cc",
|
| - "url_canon_ip.h",
|
| - "url_canon_mailtourl.cc",
|
| - "url_canon_path.cc",
|
| - "url_canon_pathurl.cc",
|
| - "url_canon_query.cc",
|
| - "url_canon_relative.cc",
|
| - "url_canon_stdstring.cc",
|
| - "url_canon_stdstring.h",
|
| - "url_canon_stdurl.cc",
|
| - "url_constants.cc",
|
| - "url_constants.h",
|
| - "url_export.h",
|
| - "url_file.h",
|
| - "url_parse_file.cc",
|
| - "url_parse_internal.h",
|
| - "url_util.cc",
|
| - "url_util.h",
|
| -]
|
| -
|
| component("url") {
|
| - sources = url_shared_sources + [
|
| - "url_canon_icu.cc",
|
| - "url_canon_icu.h",
|
| - ]
|
| + sources = [
|
| + "gurl.cc",
|
| + "gurl.h",
|
| + "origin.cc",
|
| + "origin.h",
|
| + "scheme_host_port.cc",
|
| + "scheme_host_port.h",
|
| + "third_party/mozilla/url_parse.cc",
|
| + "third_party/mozilla/url_parse.h",
|
| + "url_canon.h",
|
| + "url_canon_etc.cc",
|
| + "url_canon_filesystemurl.cc",
|
| + "url_canon_fileurl.cc",
|
| + "url_canon_host.cc",
|
| + "url_canon_internal.cc",
|
| + "url_canon_internal.h",
|
| + "url_canon_internal_file.h",
|
| + "url_canon_ip.cc",
|
| + "url_canon_ip.h",
|
| + "url_canon_mailtourl.cc",
|
| + "url_canon_path.cc",
|
| + "url_canon_pathurl.cc",
|
| + "url_canon_query.cc",
|
| + "url_canon_relative.cc",
|
| + "url_canon_stdstring.cc",
|
| + "url_canon_stdstring.h",
|
| + "url_canon_stdurl.cc",
|
| + "url_constants.cc",
|
| + "url_constants.h",
|
| + "url_export.h",
|
| + "url_file.h",
|
| + "url_parse_file.cc",
|
| + "url_parse_internal.h",
|
| + "url_util.cc",
|
| + "url_util.h",
|
| + ]
|
|
|
| - if (is_win) {
|
| - # Don't conflict with Windows' "url.dll".
|
| - output_name = "url_lib"
|
| - }
|
| defines = [ "URL_IMPLEMENTATION" ]
|
|
|
| configs += [
|
| @@ -66,9 +57,41 @@ component("url") {
|
| deps = [
|
| "//base",
|
| "//base/third_party/dynamic_annotations",
|
| - "//third_party/icu",
|
| - "//third_party/icu:icudata",
|
| ]
|
| +
|
| + if (is_win) {
|
| + # Don't conflict with Windows' "url.dll".
|
| + output_name = "url_lib"
|
| + }
|
| +
|
| + # ICU support.
|
| + if (is_android && use_icu_alternatives) {
|
| + sources += [
|
| + "android/url_jni_registrar.cc",
|
| + "android/url_jni_registrar.h",
|
| + "url_canon_icu_alternatives_android.cc",
|
| + "url_canon_icu_alternatives_android.h",
|
| + ]
|
| + defines += [ "USE_ICU_ALTERNATIVES_ON_ANDROID=1" ]
|
| + deps += [
|
| + ":url_java",
|
| + ":url_jni_headers",
|
| + "//base",
|
| + "//base/third_party/dynamic_annotations",
|
| + ]
|
| + } else if (is_ios && use_icu_alternatives) {
|
| + sources += [ "url_canon_icu_alternatives_ios.mm" ]
|
| + defines += [ "USE_ICU_ALTERNATIVES_ON_IOS=1" ]
|
| + } else { # use third-party ICU implementation.
|
| + sources += [
|
| + "url_canon_icu.cc",
|
| + "url_canon_icu.h",
|
| + ]
|
| + deps += [
|
| + "//third_party/icu",
|
| + "//third_party/icu:icudata",
|
| + ]
|
| + }
|
| }
|
|
|
| if (is_android) {
|
| @@ -85,32 +108,6 @@ if (is_android) {
|
| ]
|
| jni_package = "url"
|
| }
|
| -
|
| - component("url_lib_use_icu_alternatives_on_android") {
|
| - sources = url_shared_sources + [
|
| - "android/url_jni_registrar.cc",
|
| - "android/url_jni_registrar.h",
|
| - "url_canon_icu_alternatives_android.cc",
|
| - "url_canon_icu_alternatives_android.h",
|
| - ]
|
| -
|
| - defines = [
|
| - "URL_IMPLEMENTATION",
|
| - "USE_ICU_ALTERNATIVES_ON_ANDROID=1",
|
| - ]
|
| -
|
| - configs += [
|
| - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
|
| - "//build/config/compiler:no_size_t_to_int_warning",
|
| - ]
|
| -
|
| - deps = [
|
| - ":url_java",
|
| - ":url_jni_headers",
|
| - "//base",
|
| - "//base/third_party/dynamic_annotations",
|
| - ]
|
| - }
|
| }
|
|
|
| test("url_unittests") {
|
| @@ -130,6 +127,26 @@ test("url_unittests") {
|
| sources += [ "mojo/url_gurl_struct_traits_unittest.cc" ]
|
| }
|
|
|
| + # Unit tests that are not supported by the current ICU alternatives on Android.
|
| + if (is_android && use_icu_alternatives) {
|
| + sources -= [
|
| + "origin_unittest.cc",
|
| + "scheme_host_port_unittest.cc",
|
| + "url_canon_icu_unittest.cc",
|
| + "url_canon_unittest.cc",
|
| + ]
|
| + }
|
| +
|
| + #Unit tests that are not supported by the current ICU alternatives on iOS.
|
| + if (is_ios && use_icu_alternatives) {
|
| + sources -= [
|
| + "origin_unittest.cc",
|
| + "scheme_host_port_unittest.cc",
|
| + "url_canon_icu_unittest.cc",
|
| + "url_canon_unittest.cc",
|
| + ]
|
| + }
|
| +
|
| # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
|
| configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
|
|
|
|
|