Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed GN on iOS Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/tools/cr_cronet.py
diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py
index bb19362d647bd6f88ecd2da5c732969684e55ec0..d13535e40ce466e89a12348f2e1eefce81bced7e 100755
--- a/components/cronet/tools/cr_cronet.py
+++ b/components/cronet/tools/cr_cronet.py
@@ -70,10 +70,10 @@ def main():
print extra_options_list
gyp_defines = 'GYP_DEFINES="OS=android enable_websockets=0 '+ \
'disable_file_support=1 disable_ftp_support=1 '+ \
- 'enable_errorprone=1"'
+ 'enable_errorprone=1 use_icu_alternatives=1"'
gn_args = 'target_os="android" enable_websockets=false '+ \
'disable_file_support=true disable_ftp_support=true '+ \
- 'use_errorprone_java_compiler=true'
+ 'use_errorprone_java_compiler=true use_icu_alternatives=true'
out_dir = 'out/Debug'
release_arg = ''
extra_options = ' '.join(extra_options_list)

Powered by Google App Engine
This is Rietveld 408576698