components/cronet/tools/cr_cronet.py - Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolved rebase conflicts Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/cronet_library_loader.cc ('K') | « components/cronet/android/cronet_library_loader.cc ('k') | components/data_reduction_proxy.gypi » ('j') | components/data_reduction_proxy.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/tools/cr_cronet.py

diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py

index bb19362d647bd6f88ecd2da5c732969684e55ec0..56cc74ee4d0cbd96572cd050292e1d976835f0e0 100755

--- a/components/cronet/tools/cr_cronet.py

+++ b/components/cronet/tools/cr_cronet.py

@@ -70,10 +70,12 @@ def main():

print extra_options_list

gyp_defines = 'GYP_DEFINES="OS=android enable_websockets=0 '+ \

'disable_file_support=1 disable_ftp_support=1 '+ \

- 'enable_errorprone=1"'

+ 'enable_errorprone=1 use_platform_icu_alternatives=1 ' + \

+ 'disable_brotli_filter=1"'

gn_args = 'target_os="android" enable_websockets=false '+ \

'disable_file_support=true disable_ftp_support=true '+ \

- 'use_errorprone_java_compiler=true'

+ 'use_errorprone_java_compiler=true use_platform_icu_alternatives=true '+ \

+ 'disable_brotli_filter=true'

out_dir = 'out/Debug'

release_arg = ''

extra_options = ' '.join(extra_options_list)