Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Side by Side Diff: url/url_canon_icu_alternatives_ios.mm

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed GN on iOS Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« net/net.gyp ('K') | « url/url.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <string.h>
6
7 #include "base/strings/string16.h"
8 #include "base/strings/string_piece.h"
9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h"
11 #include "url/url_canon_internal.h"
12
13 namespace url {
14
15 // Only allow ASCII in Cronet on iOS to avoid ICU dependency. Use NSString+IDN
xunjieli 2016/03/31 13:59:41 Can we be more general and not mention Cronet in t
kapishnikov 2016/03/31 16:25:52 Done.
16 // to convert non-ASCII URL prior to passing to API.
17 bool IDNToASCII(const base::char16* src, int src_len, CanonOutputW* output) {
18 if (base::IsStringASCII(base::StringPiece16(src, src_len))) {
19 output->Append(src, src_len);
20 return true;
21 }
22 DCHECK(false) << "IDN URL support is not available.";
23 return false;
24 }
25
26 } // namespace url
OLDNEW
« net/net.gyp ('K') | « url/url.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698