url/features.gni - Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: url/features.gni

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Misha's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Features used by targets inside and outside of \|url\|.

	6 # For details see declare_args() in build/config/BUILDCONFIG.gn.

	7 declare_args() {

	8 # Enables the use of ICU alternatives in lieu of the third-party ICU implement ation.
	brettw 2016/04/04 22:54:11 This should mention what the scipr of the alternat This should mention what the scipr of the alternatives is. From the placement of this, it looks like it only affects url parsing and above, but not blink? That seems surprising to me, but I guess this is only for cronet. In that case, we should be explicit about this here. Also: 80 cols. kapishnikov 2016/04/05 15:22:04 Done. Show quoted text On 2016/04/04 22:54:11, brettw wrote: > This should mention what the scipr of the alternatives is. From the placement of > this, it looks like it only affects url parsing and above, but not blink? That > seems surprising to me, but I guess this is only for cronet. In that case, we > should be explicit about this here. > > Also: 80 cols. Done.
	9 use_platform_icu_alternatives = false

	10 }

OLD	NEW

« url/BUILD.gn ('K') | « url/android/url_jni_registrar.cc ('k') | url/url.gyp » ('j') | url/url.gyp » ('J')