Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: components/data_reduction_proxy/core/browser/BUILD.gn

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Misha's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 browser_sources = [ 5 browser_sources = [
6 "data_reduction_proxy_bypass_protocol.cc", 6 "data_reduction_proxy_bypass_protocol.cc",
7 "data_reduction_proxy_bypass_protocol.h", 7 "data_reduction_proxy_bypass_protocol.h",
8 "data_reduction_proxy_bypass_stats.cc", 8 "data_reduction_proxy_bypass_stats.cc",
9 "data_reduction_proxy_bypass_stats.h", 9 "data_reduction_proxy_bypass_stats.h",
10 "data_reduction_proxy_compression_stats.cc", 10 "data_reduction_proxy_compression_stats.cc",
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 "db_data_owner.cc", 45 "db_data_owner.cc",
46 "db_data_owner.h", 46 "db_data_owner.h",
47 ] 47 ]
48 48
49 if (is_android) { 49 if (is_android) {
50 source_set("browser_small") { 50 source_set("browser_small") {
51 sources = browser_sources 51 sources = browser_sources
52 52
53 deps = [ 53 deps = [
54 "//base", 54 "//base",
55 "//components/data_reduction_proxy/core/common:common_small", 55 "//components/data_reduction_proxy/core/common:common",
brettw 2016/04/04 22:54:11 As mef says below, don't duplicate the target name
kapishnikov 2016/04/05 15:22:04 Done.
56 "//components/data_reduction_proxy/proto:data_reduction_proxy_proto", 56 "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
57 "//components/pref_registry", 57 "//components/pref_registry",
58 "//components/prefs", 58 "//components/prefs",
59 "//components/variations", 59 "//components/variations",
60 "//crypto", 60 "//crypto",
61 "//google_apis:google_apis_small", 61 "//google_apis:google_apis",
mef 2016/04/04 22:25:43 it seems that usually we don't repeat target name
kapishnikov 2016/04/05 15:22:04 Done.
62 "//net:net_small", 62 "//net:net",
63 "//url:url_lib_use_icu_alternatives_on_android", 63 "//url:url",
64 ] 64 ]
65 } 65 }
66 } 66 }
67 67
68 source_set("browser") { 68 source_set("browser") {
69 sources = browser_sources 69 sources = browser_sources
70 sources += [ 70 sources += [
mef 2016/04/04 22:25:43 bengr: Would it make sense to extract data_store_i
71 "data_store_impl.cc", 71 "data_store_impl.cc",
72 "data_store_impl.h", 72 "data_store_impl.h",
73 ] 73 ]
74 74
75 deps = [ 75 deps = [
76 "//base", 76 "//base",
77 "//components/data_reduction_proxy/core/common", 77 "//components/data_reduction_proxy/core/common",
78 "//components/data_reduction_proxy/proto:data_reduction_proxy_proto", 78 "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
79 "//components/pref_registry", 79 "//components/pref_registry",
80 "//components/prefs", 80 "//components/prefs",
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 "//base/test:test_support", 153 "//base/test:test_support",
154 "//components/data_reduction_proxy/core/common:test_support", 154 "//components/data_reduction_proxy/core/common:test_support",
155 "//components/data_reduction_proxy/proto:data_reduction_proxy_proto", 155 "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
156 "//components/prefs:test_support", 156 "//components/prefs:test_support",
157 "//components/variations", 157 "//components/variations",
158 "//net:test_support", 158 "//net:test_support",
159 "//testing/gmock", 159 "//testing/gmock",
160 "//testing/gtest", 160 "//testing/gtest",
161 ] 161 ]
162 } 162 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698