components/cronet/tools/cr_cronet.py - Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests.

Side by Side Diff: components/cronet/tools/cr_cronet.py

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Misha's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/cronet/android/BUILD.gn ('K') | « components/cronet/android/cronet_library_loader.cc ('k') | components/data_reduction_proxy.gypi » ('j') | components/data_reduction_proxy/core/browser/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 #!/usr/bin/python	1 #!/usr/bin/python

2 # Copyright 2014 The Chromium Authors. All rights reserved.	2 # Copyright 2014 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 """	6 """

7 cr_cronet.py - cr - like helper tool for cronet developers	7 cr_cronet.py - cr - like helper tool for cronet developers

8 """	8 """

9	9

10 import argparse	10 import argparse

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 'debug',	63 'debug',

64 'build-debug'])	64 'build-debug'])

65 parser.add_argument('-r', '--release', action='store_true',	65 parser.add_argument('-r', '--release', action='store_true',

66 help='use release configuration')	66 help='use release configuration')

67	67

68 options, extra_options_list = parser.parse_known_args()	68 options, extra_options_list = parser.parse_known_args()

69 print options	69 print options

70 print extra_options_list	70 print extra_options_list

71 gyp_defines = 'GYP_DEFINES="OS=android enable_websockets=0 '+ \	71 gyp_defines = 'GYP_DEFINES="OS=android enable_websockets=0 '+ \

72 'disable_file_support=1 disable_ftp_support=1 '+ \	72 'disable_file_support=1 disable_ftp_support=1 '+ \

73 'enable_errorprone=1"'	73 'enable_errorprone=1 use_platform_icu_alternatives=1 ' + \

	74 'disable_brotli_filter=1"'

74 gn_args = 'target_os="android" enable_websockets=false '+ \	75 gn_args = 'target_os="android" enable_websockets=false '+ \

75 'disable_file_support=true disable_ftp_support=true '+ \	76 'disable_file_support=true disable_ftp_support=true '+ \

76 'use_errorprone_java_compiler=true'	77 'use_errorprone_java_compiler=true use_platform_icu_alternatives=true '+ \

	78 'disable_brotli_filter=true'

77 out_dir = 'out/Debug'	79 out_dir = 'out/Debug'

78 release_arg = ''	80 release_arg = ''

79 extra_options = ' '.join(extra_options_list)	81 extra_options = ' '.join(extra_options_list)

80 if options.release:	82 if options.release:

81 out_dir = 'out/Release'	83 out_dir = 'out/Release'

82 release_arg = ' --release'	84 release_arg = ' --release'

83 gn_args += ' is_debug=false '	85 gn_args += ' is_debug=false '

84	86

85 if (options.command=='gyp'):	87 if (options.command=='gyp'):

86 return run (gyp_defines + ' gclient runhooks')	88 return run (gyp_defines + ' gclient runhooks')

(...skipping 18 matching lines...) Expand all Loading...
105 return install(release_arg) or debug(extra_options)	107 return install(release_arg) or debug(extra_options)

106 if (options.command=='build-debug'):	108 if (options.command=='build-debug'):

107 return build(out_dir) or install(release_arg) or debug(extra_options)	109 return build(out_dir) or install(release_arg) or debug(extra_options)

108	110

109 parser.print_help()	111 parser.print_help()

110 return 1	112 return 1

111	113

112	114

113 if __name__ == '__main__':	115 if __name__ == '__main__':

114 sys.exit(main())	116 sys.exit(main())

OLD	NEW