Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: components/cronet/android/BUILD.gn

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Misha's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 import("//build/util/version.gni") 8 import("//build/util/version.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 182
183 if (defined(invoker.deps)) { 183 if (defined(invoker.deps)) {
184 deps += invoker.deps 184 deps += invoker.deps
185 } 185 }
186 } 186 }
187 } 187 }
188 188
189 # cronet_static_small target has reduced binary size through using 189 # cronet_static_small target has reduced binary size through using
190 # ICU alternatives which requires file and ftp support be disabled. 190 # ICU alternatives which requires file and ftp support be disabled.
191 cronet_static_tmpl("cronet_static_small") { 191 cronet_static_tmpl("cronet_static_small") {
192 defines = [
193 "USE_ICU_ALTERNATIVES_ON_ANDROID=1",
194 "DISABLE_FILE_SUPPORT=1",
195 "DISABLE_FTP_SUPPORT=1",
196 ]
197
198 deps = [ 192 deps = [
199 "//net:net_small", 193 "//net:net",
brettw 2016/04/04 22:54:11 Just "//net" and "//url" here.
kapishnikov 2016/04/05 15:22:04 Done.
200 "//url:url_lib_use_icu_alternatives_on_android", 194 "//url:url",
201 ] 195 ]
202 196
203 if (cronet_enable_data_reduction_proxy_support) { 197 if (cronet_enable_data_reduction_proxy_support) {
204 deps += [ 198 deps += [
205 "//components/data_reduction_proxy/core/browser:browser_small", 199 "//components/data_reduction_proxy/core/browser:browser_small",
206 "//components/data_reduction_proxy/core/common:common_small", 200 "//components/data_reduction_proxy/core/common:common_small",
mef 2016/04/04 22:25:43 it seems that common_small target is no longer def
kapishnikov 2016/04/05 15:22:04 Done.
207 ] 201 ]
208 } 202 }
209 } 203 }
210 204
211 # cronet_static target depends on ICU and includes file and ftp support. 205 # cronet_static target depends on ICU and includes file and ftp support.
212 cronet_static_tmpl("cronet_static") { 206 cronet_static_tmpl("cronet_static") {
213 deps = [ 207 deps = [
214 "//base:i18n", 208 "//base:i18n",
215 "//net", 209 "//net",
216 "//url", 210 "//url",
217 ] 211 ]
218 212
219 if (cronet_enable_data_reduction_proxy_support) { 213 if (cronet_enable_data_reduction_proxy_support) {
220 deps += [ 214 deps += [
221 "//components/data_reduction_proxy/core/browser", 215 "//components/data_reduction_proxy/core/browser",
222 "//components/data_reduction_proxy/core/common", 216 "//components/data_reduction_proxy/core/common",
223 ] 217 ]
224 } 218 }
225 } 219 }
226 220
227 shared_library("cronet") { 221 shared_library("cronet") {
228 sources = [ 222 sources = [
229 "cronet_jni.cc", 223 "cronet_jni.cc",
230 ] 224 ]
231 deps = [ 225 deps = [
232 ":cronet_static_small", 226 ":cronet_static_small",
233 "//base", 227 "//base",
234 "//net:net_small", 228 "//net:net",
235 ] 229 ]
236 ldflags = [ "-Wl,--version-script=" + 230 ldflags = [ "-Wl,--version-script=" +
237 rebase_path("//components/cronet/android/only_jni_exports.lst") ] 231 rebase_path("//components/cronet/android/only_jni_exports.lst") ]
238 232
239 # Avoid hide_native_jni_exports as it adds another version script, and the 233 # Avoid hide_native_jni_exports as it adds another version script, and the
240 # ARM64 linker throws an error for multiple version scripts with anonymous 234 # ARM64 linker throws an error for multiple version scripts with anonymous
241 # version tags. 235 # version tags.
242 configs -= [ "//build/config/android:hide_native_jni_exports" ] 236 configs -= [ "//build/config/android:hide_native_jni_exports" ]
243 } 237 }
244 238
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 ":cronet_package_copy_native_lib", 875 ":cronet_package_copy_native_lib",
882 ":cronet_package_copy_native_lib_unstripped", 876 ":cronet_package_copy_native_lib_unstripped",
883 ":generate_javadoc", 877 ":generate_javadoc",
884 ":generate_licenses", 878 ":generate_licenses",
885 ":jar_cronet_api_source", 879 ":jar_cronet_api_source",
886 ":jar_cronet_other_source", 880 ":jar_cronet_other_source",
887 ":jar_cronet_sample_source", 881 ":jar_cronet_sample_source",
888 ":repackage_extracted_jars", 882 ":repackage_extracted_jars",
889 ] 883 ]
890 } 884 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698