Remove IDBNotFoundError ExceptionCode

Source/bindings/v8/ExceptionState.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 11 matching lines @@
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
-#include "core/dom/NodeList.h"
+#include "bindings/v8/ExceptionState.h"
 
-#include "core/dom/Node.h"
+#include "bindings/v8/V8ThrowException.h"
+#include "core/dom/ExceptionCode.h"
 
 namespace WebCore {
 
-void NodeList::anonymousNamedGetter(const AtomicString& name, bool& returnValue0Enabled, RefPtr<Node>& returnValue0, bool& returnValue1Enabled, unsigned& returnValue1)
+void ExceptionState::throwDOMException(const ExceptionCode& ec,  const char* message)
 {
-    // Length property cannot be overridden.
-    DEFINE_STATIC_LOCAL(const AtomicString, length, ("length", AtomicString::ConstructFromLiteral));
-    if (name == length) {
-        returnValue1Enabled = true;
-        returnValue1 = this->length();
+    if (m_exceptionThrown)

[jsbell, 2013/07/10 00:41:31]

Out of curiosity, do we ever hit this case? Perhaps in the future we should
ASSERT here, as it would mean some algorithm is not terminating after throwing
when it should.

(There's probably somewhere in the platform that does the equivalent of an "if
those steps threw, throw XYZ instead" which perhaps should be made explicit.)

Anyway, not for this patch.

[arv (Not doing code reviews), 2013/07/10 02:12:59]

An assert would be good. I'll add that.

The end goal is to not have to keep track of m_exceptionThrown or m_code.

         return;
-    }
-
-    Node* result = namedItem(name);
-    if (!result)
-        return;
-
-    returnValue0Enabled = true;
-    returnValue0 = result;
+    V8ThrowException::setDOMException(ec, message, m_isolate);
+    m_exceptionThrown = true;
 }
 
+void ExceptionState::throwTypeError(const char* message)
+{
+    if (m_exceptionThrown)
+        return;
+    V8ThrowException::throwTypeError(message, m_isolate);
+    m_exceptionThrown = true;
+}
+
+NonThrowExceptionState::NonThrowExceptionState()
+    : ExceptionState(0) { }
+
+void NonThrowExceptionState::throwDOMException(const ExceptionCode& ec, const char*)
+{
+    m_code = ec;
+}
+
+void NonThrowExceptionState::throwTypeError(const char*)
+{
+    m_code = TypeError;
+}
 
 } // namespace WebCore