Remove IDBNotFoundError ExceptionCode

Source/modules/indexeddb/IDBTransaction.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
  *     documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/indexeddb/IDBTransaction.h"
 
+#include "bindings/v8/ExceptionState.h"
 #include "core/dom/DOMError.h"
 #include "core/dom/EventQueue.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExceptionCodePlaceholder.h"
 #include "core/dom/ScriptExecutionContext.h"
 #include "core/inspector/ScriptCallStack.h"
 #include "modules/indexeddb/IDBDatabase.h"
 #include "modules/indexeddb/IDBEventDispatcher.h"
 #include "modules/indexeddb/IDBIndex.h"
 #include "modules/indexeddb/IDBObjectStore.h"
@@ skipping 90 matching lines @@
     ASSERT(m_state != Finished);
     ASSERT(error);
 
     // The first error to be set is the true cause of the
     // transaction abort.
     if (!m_error) {
         m_error = error;
     }
 }
 
-PassRefPtr<IDBObjectStore> IDBTransaction::objectStore(const String& name, ExceptionCode& ec)
+PassRefPtr<IDBObjectStore> IDBTransaction::objectStore(const String& name, ExceptionState& es)
 {
     if (m_state == Finished) {
-        ec = INVALID_STATE_ERR;
+        es.throwDOMException(INVALID_STATE_ERR);
         return 0;
     }
 
     IDBObjectStoreMap::iterator it = m_objectStoreMap.find(name);
     if (it != m_objectStoreMap.end())
         return it->value;
 
     if (!isVersionChange() && !m_objectStoreNames.contains(name)) {
-        // FIXME: Should use (NotFoundError, "...").
-        ec = IDBNotFoundError;
+        // FIXME: Should use constant
+        es.throwDOMException(NOT_FOUND_ERR, "An operation failed because the requested database object could not be found.");
         return 0;
     }
 
     int64_t objectStoreId = m_database->findObjectStoreId(name);
     if (objectStoreId == IDBObjectStoreMetadata::InvalidId) {
         ASSERT(isVersionChange());
-        // FIXME: Should use (NotFoundError, "...").
-        ec = IDBNotFoundError;
+        // FIXME: Should use constant
+        es.throwDOMException(NOT_FOUND_ERR, "An operation failed because the requested database object could not be found.");
         return 0;
     }
 
     const IDBDatabaseMetadata& metadata = m_database->metadata();
 
     RefPtr<IDBObjectStore> objectStore = IDBObjectStore::create(metadata.objectStores.get(objectStoreId), this);
     objectStoreCreated(name, objectStore);
     return objectStore.release();
 }
 
@@ skipping 155 matching lines @@
 }
 
 bool IDBTransaction::hasPendingActivity() const
 {
     // FIXME: In an ideal world, we should return true as long as anyone has a or can
     //        get a handle to us or any child request object and any of those have
     //        event listeners. This is  in order to handle user generated events properly.
     return m_hasPendingActivity && !m_contextStopped;
 }
 
 IndexedDB::TransactionMode IDBTransaction::stringToMode(const String& modeString, ExceptionCode& ec)

[jsbell, 2013/07/02 18:48:08]

Still needs updating, obviously. (Hence the DO NOT SUBMIT)

 {
     if (modeString.isNull()
         || modeString == IDBTransaction::modeReadOnly())
         return IndexedDB::TransactionReadOnly;
     if (modeString == IDBTransaction::modeReadWrite())
         return IndexedDB::TransactionReadWrite;
 
     ec = TypeError;

[jsbell, 2013/07/02 18:48:08]

This will become es.throwTypeError(), but es.throwDOMException(TypeError) would
work for now?

     return IndexedDB::TransactionReadOnly;
 }
 
 const AtomicString& IDBTransaction::modeToString(IndexedDB::TransactionMode mode)
 {
     switch (mode) {
     case IndexedDB::TransactionReadOnly:
         return IDBTransaction::modeReadOnly();
         break;
 
@@ skipping 91 matching lines @@
 {
     return &m_eventTargetData;
 }
 
 IDBDatabaseBackendInterface* IDBTransaction::backendDB() const
 {
     return db()->backend();
 }
 
 } // namespace WebCore