Remove IDBNotFoundError ExceptionCode

Source/core/dom/DOMException.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 20 matching lines @@
 
 #include "ExceptionCode.h"
 
 namespace WebCore {
 
 static struct CoreException {
     const char* const name;
     const char* const message;
     const int code;
 } coreExceptions[] = {
     { "IndexSizeError", "Index or size was negative, or greater than the allowed value.", 1 },

[arv (Not doing code reviews), 2013/07/01 22:29:31]

I'm tempted to use an .in file for this table and generate something better than
this table.

     { "HierarchyRequestError", "A Node was inserted somewhere it doesn't belong.", 3 },
     { "WrongDocumentError", "A Node was used in a different document than the one that created it (that doesn't support it).", 4 },
     { "InvalidCharacterError", "An invalid or illegal character was specified, such as in an XML name.", 5 },
     { "NoModificationAllowedError", "An attempt was made to modify an object where modifications are not allowed.", 7 },
     { "NotFoundError", "An attempt was made to reference a Node in a context where it does not exist.", 8 },
     { "NotSupportedError", "The implementation did not support the requested type of object or operation.", 9 },
     { "InUseAttributeError", "An attempt was made to add an attribute that is already in use elsewhere.", 10 },
     { "InvalidStateError", "An attempt was made to use an object that is not, or is no longer, usable.", 11 },
     { "SyntaxError", "An invalid or illegal string was specified.", 12 },
     { "InvalidModificationError", "An attempt was made to modify the type of the underlying object.", 13 },
     { "NamespaceError", "An attempt was made to create or change an object in a way which is incorrect with regard to namespaces.", 14 },
     { "InvalidAccessError", "A parameter or an operation was not supported by the underlying object.", 15 },
     { "TypeMismatchError", "The type of an object was incompatible with the expected type of the parameter associated to the object.", 17 },
     { "SecurityError", "An attempt was made to break through the security policy of the user agent.", 18 },
     { "NetworkError", "A network error occurred.", 19 },
     { "AbortError", "The user aborted a request.", 20 },
     { "URLMismatchError", "A worker global scope represented an absolute URL that is not equal to the resulting absolute URL.", 21 },
     { "QuotaExceededError", "An attempt was made to add something to storage that exceeded the quota.", 22 },
     { "TimeoutError", "A timeout occurred.", 23 },
     { "InvalidNodeTypeError", "The supplied node is invalid or has an invalid ancestor for this operation.", 24 },
     { "DataCloneError", "An object could not be cloned.", 25 },
 
-    // These are IDB-specific errors.
-    // FIXME: NotFoundError is duplicated to have a more specific error message.
-    // https://code.google.com/p/chromium/issues/detail?id=252233
-    { "NotFoundError", "An operation failed because the requested database object could not be found.", 8 },
-
-    // More IDB-specific errors.
+    // Indexed DB
     { "UnknownError", "An unknown error occurred within Indexed Database.", 0 },
     { "ConstraintError", "A mutation operation in the transaction failed because a constraint was not satisfied.", 0 },
     { "DataError", "The data provided does not meet requirements.", 0 },
     { "TransactionInactiveError", "A request was placed against a transaction which is either currently not active, or which is finished.", 0 },
     { "ReadOnlyError", "A write operation was attempted in a read-only transaction.", 0 },
     { "VersionError", "An attempt was made to open a database using a lower version than the existing version.", 0 },
 
     // File system
     { "NotFoundError", "A requested file or directory could not be found at the time an operation was processed.", 8 },
     { "SecurityError", "It was determined that certain files are unsafe for access within a Web application, or that too many calls are being made on file resources.", 18 },
@@ skipping 20 matching lines @@
 };
 
 static const CoreException* getErrorEntry(ExceptionCode ec)
 {
     size_t tableSize = WTF_ARRAY_LENGTH(coreExceptions);
     size_t tableIndex = ec - INDEX_SIZE_ERR;
 
     return tableIndex < tableSize ? &coreExceptions[tableIndex] : 0;
 }
 
-DOMException::DOMException(ExceptionCode ec)
+DOMException::DOMException(unsigned short code, const char* name, const char * message)
+{
+    ASSERT(name);
+    m_code = code;
+    m_name = name;
+    m_message = message;
+    ScriptWrappable::init(this);
+}
+
+PassRefPtr<DOMException> DOMException::create(ExceptionCode ec, const char* message)
 {
     const CoreException* entry = getErrorEntry(ec);
     ASSERT(entry);
-    if (!entry) {
-        m_code = 0;
-        m_name = "UnknownError";
-        m_message = "Unknown Error";
-    } else {
-        m_code = entry->code;
-        if (entry->name)
-            m_name = entry->name;
-        else
-            m_name = "Error";
-        m_message = entry->message;
-    }
-
-    ScriptWrappable::init(this);
-}
-
-PassRefPtr<DOMException> DOMException::create(ExceptionCode ec)
-{
-    return adoptRef(new DOMException(ec));
+    return adoptRef(new DOMException(entry->code, entry->name ? entry->name : "Error", message ? message : entry->message));
 }
 
 String DOMException::toString() const
 {
     return name() + ": " + message();
 }
 
 String DOMException::getErrorName(ExceptionCode ec)
 {
     const CoreException* entry = getErrorEntry(ec);
@@ skipping 16 matching lines @@
 
 unsigned short DOMException::getLegacyErrorCode(ExceptionCode ec)
 {
     const CoreException* entry = getErrorEntry(ec);
     ASSERT(entry);
 
     return (entry && entry->code) ? entry->code : 0;
 }
 
 } // namespace WebCore