Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1839783002: Revert of Enable DRP config service by default (Closed)

Created:
4 years, 8 months ago by tbansal1
Modified:
4 years, 8 months ago
Reviewers:
Steven Holte, sclittle
CC:
chromium-reviews, asvitkine+watch_chromium.org, jpfeiff
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable DRP config service by default (patchset #3 id:80001 of https://codereview.chromium.org/1830343002/ ) Reason for revert: Reverting because this broke Cronet tests: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/1601 Original issue's description: > Enable DRP config service by default > > We have been running this experiment at 50% stable, and are > now ready to move to 100%. > > This CL does not remove the code that will now be deprecated > because of DRP config being enabled 100% of time. We should > remove that code at some point in future. > > BUG=597768 > > Committed: https://crrev.com/849951145321fe4f254e87496a855631c6e777e4 > Cr-Commit-Position: refs/heads/master@{#383527} TBR=sclittle@chromium.org,holte@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597768 Committed: https://crrev.com/270c4efdb844a9aaf671c0e618da9d5c6843980c Cr-Commit-Position: refs/heads/master@{#383567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -5 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc View 4 chunks +101 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_ios.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tbansal1
Created Revert of Enable DRP config service by default
4 years, 8 months ago (2016-03-28 21:28:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839783002/1
4 years, 8 months ago (2016-03-28 21:28:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 21:29:05 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 21:30:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/270c4efdb844a9aaf671c0e618da9d5c6843980c
Cr-Commit-Position: refs/heads/master@{#383567}

Powered by Google App Engine
This is Rietveld 408576698