Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/bisect-builds.py

Issue 1839763009: ignore git hash revisions for chromium-browser-snapshots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-builds.py
diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py
index 2ff6126f57744799b5c1aaa8ed38d98a97868362..e2c577d318411e89f4bb40ed1848365192cd4202 100755
--- a/tools/bisect-builds.py
+++ b/tools/bisect-builds.py
@@ -316,21 +316,12 @@ class PathContext(object):
for prefix in all_prefixes:
revnum = prefix.text[prefix_len:-1]
try:
- if not revnum.isdigit():
- # During the svn-git migration, some items were stored by hash.
- # These items may appear anywhere in the list of items.
- # If |last_known_rev| is set, assume that the full list has been
- # retrieved before (including the hashes), so we can safely skip
- # all git hashes and focus on the numeric revision numbers.
- if last_known_rev:
- revnum = None
- else:
- git_hash = revnum
- revnum = self.GetSVNRevisionFromGitHash(git_hash)
- githash_svn_dict[revnum] = git_hash
- if revnum is not None:
- revnum = int(revnum)
- revisions.append(revnum)
+ revnum = int(revnum)
+ revisions.append(revnum)
+ # Notes:
+ # Ignore hash in chromium-browser-snapshots as they are invalid
+ # Resulting in 404 error in fetching pages:
+ # https://chromium.googlesource.com/chromium/src/+/[rev_hash]
except ValueError:
pass
return (revisions, next_marker, githash_svn_dict)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698