Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1839763008: [Autofill] Correctly fill month selects where the first value is negative. (Closed)

Created:
4 years, 8 months ago by sebsg
Modified:
4 years, 8 months ago
Reviewers:
Mathieu
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

On some sites the value corresponding to the placeholder month is "-1". For cases where the first value associated with a placeholder is negative, Autofill now looks at the next value in order to fill the correct month. A real life example is the credit card checkout at aa.com BUG=598929 TEST=AutofillFieldTest Committed: https://crrev.com/f878d61e4fc8c403df8fd621339c2481df531ff0 Cr-Commit-Position: refs/heads/master@{#384152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M components/autofill/core/browser/autofill_field.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sebsg
Hi Math, could you please take a look? Thanks!
4 years, 8 months ago (2016-03-30 22:41:46 UTC) #6
Mathieu
lgtm
4 years, 8 months ago (2016-03-30 23:08:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839763008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839763008/20001
4 years, 8 months ago (2016-03-30 23:08:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-03-31 00:06:46 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 00:08:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f878d61e4fc8c403df8fd621339c2481df531ff0
Cr-Commit-Position: refs/heads/master@{#384152}

Powered by Google App Engine
This is Rietveld 408576698