MSE: Protect better against reaching HAVE_METADATA too early

MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to enforce StreamParsers' InitCB happens after
one or more ConfigCB, and occurs at most once per parser, is in a
later CL (https://codereview.chromium.org/1843823003/).

BUG=597447
Committed: https://crrev.com/fe1e90eeacdc473325519df9c556d1cffa5db3a0
Cr-Commit-Position: refs/heads/master@{#384085}

[wolenetz, 2016-03-29 20:37:34]

wolenetz@chromium.org changed reviewers:
+ chcunningham@chromium.org

[wolenetz, 2016-03-29 20:37:35]

PTAL

[wolenetz, 2016-03-29 20:40:54]

Description was changed from

==========
MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to coalesce StreamParser's calling of InitCB to be
done automatically as part of first ConfigCB may come in a later CL.

BUG=597447
==========

to

==========
MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to enforce StreamParsers' InitCB happens after
one or more ConfigCB, and occurs at most once per parser, may come
in a later CL.

BUG=597447
==========

[wolenetz, 2016-03-29 20:46:23]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 20:47:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839763005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839763005/1

[wolenetz, 2016-03-29 21:38:25]

On 2016/03/29 20:37:35, wolenetz wrote:
> PTAL

(Note, this will likely need to be rebased on top of
https://codereview.chromium.org/1826583003/, once that lands.)

[commit-bot: I haz the power, 2016-03-29 23:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 23:18:32]

Dry run: This issue passed the CQ dry run.

[wolenetz, 2016-03-30 18:06:09]

Description was changed from

==========
MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to enforce StreamParsers' InitCB happens after
one or more ConfigCB, and occurs at most once per parser, may come
in a later CL.

BUG=597447
==========

to

==========
MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to enforce StreamParsers' InitCB happens after
one or more ConfigCB, and occurs at most once per parser, is in a
later CL (https://codereview.chromium.org/1843823003/).

BUG=597447
==========

[wolenetz, 2016-03-30 18:06:57]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[wolenetz, 2016-03-30 18:07:17]

ping (rebase is completed in PS2, now that
https://codereview.chromium.org/1826583003/ has landed.)

[commit-bot: I haz the power, 2016-03-30 18:07:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839763005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839763005/20001

[chcunningham, 2016-03-30 20:30:50]

lgtm

[wolenetz, 2016-03-30 20:35:49]

The CQ bit was unchecked by wolenetz@chromium.org

[wolenetz, 2016-03-30 20:35:55]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2016-03-30 20:36:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839763005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839763005/20001

[commit-bot: I haz the power, 2016-03-30 20:47:45]

Description was changed from

==========
MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to enforce StreamParsers' InitCB happens after
one or more ConfigCB, and occurs at most once per parser, is in a
later CL (https://codereview.chromium.org/1843823003/).

BUG=597447
==========

to

==========
MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to enforce StreamParsers' InitCB happens after
one or more ConfigCB, and occurs at most once per parser, is in a
later CL (https://codereview.chromium.org/1843823003/).

BUG=597447
==========

[commit-bot: I haz the power, 2016-03-30 20:47:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-30 20:48:49]

Description was changed from

==========
MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to enforce StreamParsers' InitCB happens after
one or more ConfigCB, and occurs at most once per parser, is in a
later CL (https://codereview.chromium.org/1843823003/).

BUG=597447
==========

to

==========
MSE: Protect better against reaching HAVE_METADATA too early

Adds a counter of expected ChunkDemuxer::OnSourceInitDone() calls and
uses it to gate when to transition to INITIALIZED. Reduces fragility and
improves readability. This corresponds to the first part of fixing bug
597447. Refactoring to enforce StreamParsers' InitCB happens after
one or more ConfigCB, and occurs at most once per parser, is in a
later CL (https://codereview.chromium.org/1843823003/).

BUG=597447

Committed: https://crrev.com/fe1e90eeacdc473325519df9c556d1cffa5db3a0
Cr-Commit-Position: refs/heads/master@{#384085}
==========

[commit-bot: I haz the power, 2016-03-30 20:48:50]

Patchset 2 (id:??) landed as
https://crrev.com/fe1e90eeacdc473325519df9c556d1cffa5db3a0
Cr-Commit-Position: refs/heads/master@{#384085}