Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: third_party/WebKit/Source/core/editing/BackspaceStateMachineTest.cpp

Issue 1839753005: Move state machines to state_machines subdir (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: extracted machine state for other state machines. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/BackspaceStateMachineTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/BackspaceStateMachineTest.cpp b/third_party/WebKit/Source/core/editing/BackspaceStateMachineTest.cpp
index 244f72e9399864a6c60ebeabc399fa9881d6d972..f95be42a304ef14b7110e97704ca0b8d8b770df7 100644
--- a/third_party/WebKit/Source/core/editing/BackspaceStateMachineTest.cpp
+++ b/third_party/WebKit/Source/core/editing/BackspaceStateMachineTest.cpp
@@ -8,35 +8,40 @@
namespace blink {
+namespace {
+const MachineState NeedMoreCodeUnit = MachineState::NeedMoreCodeUnit;
+const MachineState Finished = MachineState::Finished;
+} // namespace
+
TEST(BackspaceStateMachineTest, DoNothingCase)
{
BackspaceStateMachine machine;
- EXPECT_EQ(0, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(0, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(0, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(0, machine.finalizeAndGetBoundaryOffset());
}
TEST(BackspaceStateMachineTest, SingleCharacter)
{
BackspaceStateMachine machine;
- EXPECT_TRUE(machine.updateState('a'));
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(Finished, machine.feedPrecedingCodeUnit('a'));
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
machine.reset();
- EXPECT_TRUE(machine.updateState('-'));
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(Finished, machine.feedPrecedingCodeUnit('-'));
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
machine.reset();
- EXPECT_TRUE(machine.updateState('\t'));
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(Finished, machine.feedPrecedingCodeUnit('\t'));
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
machine.reset();
// U+3042 HIRAGANA LETTER A.
- EXPECT_TRUE(machine.updateState(0x3042));
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(Finished, machine.feedPrecedingCodeUnit(0x3042));
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
}
TEST(BackspaceStateMachineTest, SurrogatePair)
@@ -47,35 +52,35 @@ TEST(BackspaceStateMachineTest, SurrogatePair)
uint16_t leadSurrogate = 0xD83D;
uint16_t trailSurrogate = 0xDDFA;
- EXPECT_FALSE(machine.updateState(trailSurrogate));
- EXPECT_TRUE(machine.updateState(leadSurrogate));
- EXPECT_EQ(2, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(2, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(NeedMoreCodeUnit, machine.feedPrecedingCodeUnit(trailSurrogate));
+ EXPECT_EQ(Finished, machine.feedPrecedingCodeUnit(leadSurrogate));
+ EXPECT_EQ(-2, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-2, machine.finalizeAndGetBoundaryOffset());
// Edge cases
// Unpaired trailing surrogate. Delete only broken trail surrogate.
machine.reset();
- EXPECT_FALSE(machine.updateState(trailSurrogate));
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(NeedMoreCodeUnit, machine.feedPrecedingCodeUnit(trailSurrogate));
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
machine.reset();
- EXPECT_FALSE(machine.updateState(trailSurrogate));
- EXPECT_TRUE(machine.updateState('a'));
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(NeedMoreCodeUnit, machine.feedPrecedingCodeUnit(trailSurrogate));
+ EXPECT_EQ(Finished, machine.feedPrecedingCodeUnit('a'));
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
machine.reset();
- EXPECT_FALSE(machine.updateState(trailSurrogate));
- EXPECT_TRUE(machine.updateState(trailSurrogate));
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(NeedMoreCodeUnit, machine.feedPrecedingCodeUnit(trailSurrogate));
+ EXPECT_EQ(Finished, machine.feedPrecedingCodeUnit(trailSurrogate));
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
// Unpaired leading surrogate. Delete only broken lead surrogate.
machine.reset();
- EXPECT_TRUE(machine.updateState(leadSurrogate));
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
- EXPECT_EQ(1, machine.finalizeAndGetCodeUnitCountToBeDeleted());
+ EXPECT_EQ(Finished, machine.feedPrecedingCodeUnit(leadSurrogate));
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
+ EXPECT_EQ(-1, machine.finalizeAndGetBoundaryOffset());
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698