third_party/WebKit/Source/core/editing/StateMachineCommon.h - Issue 1839753005: Move state machines to state_machines subdir

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/StateMachineCommon.h

Issue 1839753005: Move state machines to state_machines subdir (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: extracted machine state for other state machines. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/editing/BackspaceStateMachine.h ('K') | « third_party/WebKit/Source/core/editing/EditingUtilities.cpp ('k') | third_party/WebKit/Source/core/editing/StateMachineCommon.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	yosin_UTC9 2016/03/30 08:52:23 "MachineState.h" is better since this file contain "MachineState.h" is better since this file contains only \|enum class MachineState\|. Seigo Nonaka 2016/03/30 09:13:23 Sure. To meet /MachineState/TextSegmentationMachin Show quoted text On 2016/03/30 08:52:23, Yosi_UTC9 wrote: > "MachineState.h" is better since this file contains only \|enum class > MachineState\|. Sure. To meet /MachineState/TextSegmentationMachineState/ also changed this name to TextSegmentationMachineState.h
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef StateMachineCommon_h

	6 #define StateMachineCommon_h

	7

	8 #include "core/CoreExport.h"

	9 #include <ostream> // NOLINT

	10

	11 namespace blink {

	12

	13 enum class MachineState {
	yosin_UTC9 2016/03/30 08:52:23 \|MachineState\| is generic term. We need to have sp \|MachineState\| is generic term. We need to have specific one. Fumm... \|StateMachineState\|? "state machine" is generic. How about \|TextSegmentationMachine\|? Or, better one. Seigo Nonaka 2016/03/30 09:13:23 Done. Show quoted text On 2016/03/30 08:52:23, Yosi_UTC9 wrote: > \|MachineState\| is generic term. We need to have specific one. > Fumm... \|StateMachineState\|? "state machine" is generic. > > How about \|TextSegmentationMachine\|? Or, better one. Done.
	14 Invalid, // Indicates the state machine is in invalid state.

	15 NeedMoreCodeUnit, // Indicates the state machine needs more code units to tr ansit the state.

	16 NeedFollowingCodeUnit, // Indicates the state machine needs following code u nits to transit the state.

	17 Finished, // Indicates the state machine found a boundary.

	18 };

	19

	20 CORE_EXPORT std::ostream& operator << (std::ostream&, MachineState);
	yosin_UTC9 2016/03/30 08:52:23 No need to have spaces around \|<<\| No need to have spaces around \|<<\| Seigo Nonaka 2016/03/30 09:13:23 Done. Show quoted text On 2016/03/30 08:52:23, Yosi_UTC9 wrote: > No need to have spaces around \|<<\| Done.
	21

	22 } // namespace blink

	23

	24 #endif // StateMachineCommon_h

OLD	NEW