Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1839753004: cc : Fix timeout bug in LayerTreeHostTestGpuRasterDeviceSizeChanged (Closed)

Created:
4 years, 8 months ago by jaydasika
Modified:
4 years, 8 months ago
Reviewers:
danakj, sunnyps, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Fix timeout bug in LayerTreeHostTestGpuRasterDeviceSizeChanged Make sure EndTest is always reached BUG=598491 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a6d69e5b6cd301985648c92fb58faf3427c768eb Cr-Commit-Position: refs/heads/master@{#383750}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Enable the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jaydasika
PTAL
4 years, 8 months ago (2016-03-29 00:58:21 UTC) #3
jaydasika
Re-enable the test
4 years, 8 months ago (2016-03-29 16:37:12 UTC) #4
enne (OOO)
Why does this change fix the test?
4 years, 8 months ago (2016-03-29 16:54:03 UTC) #5
enne (OOO)
Oh, nevermind, I see, it's a commit vs draws mismatch. lgtm
4 years, 8 months ago (2016-03-29 16:55:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839753004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839753004/40001
4 years, 8 months ago (2016-03-29 16:57:01 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 17:13:38 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:15:49 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a6d69e5b6cd301985648c92fb58faf3427c768eb
Cr-Commit-Position: refs/heads/master@{#383750}

Powered by Google App Engine
This is Rietveld 408576698