Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1839753003: [libfuzzer] tweaking is_ubsan_security options. (Closed)

Created:
4 years, 8 months ago by aizatsky
Modified:
4 years, 8 months ago
Reviewers:
mmoroz, inferno, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] tweaking is_ubsan_security options. BUG=596650 Committed: https://crrev.com/abed7e64e8b0e13e2b66dc1c7ccfdc478ca73e93 Cr-Commit-Position: refs/heads/master@{#383594}

Patch Set 1 #

Patch Set 2 : adding define #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build/config/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/sanitizers/sanitizers.gni View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
aizatsky
4 years, 8 months ago (2016-03-28 21:47:38 UTC) #3
inferno
lgtm with a minor addition needed. can you update https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD.gn&l=173 to include is_ubsan_security
4 years, 8 months ago (2016-03-28 21:51:44 UTC) #4
aizatsky
On 2016/03/28 21:51:44, inferno wrote: > lgtm with a minor addition needed. > > can ...
4 years, 8 months ago (2016-03-28 21:54:29 UTC) #5
inferno
lgtm
4 years, 8 months ago (2016-03-28 21:55:30 UTC) #6
Dirk Pranke
lgtm
4 years, 8 months ago (2016-03-28 22:29:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839753003/20001
4 years, 8 months ago (2016-03-28 22:30:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-28 23:05:23 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:07:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/abed7e64e8b0e13e2b66dc1c7ccfdc478ca73e93
Cr-Commit-Position: refs/heads/master@{#383594}

Powered by Google App Engine
This is Rietveld 408576698