Fix GrConvexPolyEffect to deal with line paths.

Fix GrConvexPolyEffect to deal with line paths.

BUG=skia:4727
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1839743002

Committed: https://skia.googlesource.com/skia/+/7888de0db74ac08162c85903a71a48f6d2a3013f

[bsalomon, 2016-03-28 20:47:40]

Description was changed from

==========
Fix GrConvexPolyEffect to deal with line paths.

BUG=skia:4727
==========

to

==========
Fix GrConvexPolyEffect to deal with line paths.

BUG=skia:4727
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-28 20:49:39]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-03-28 21:42:13]

lgtm with a couple questions

https://codereview.chromium.org/1839743002/diff/40001/gm/convexpolyeffect.cpp
File gm/convexpolyeffect.cpp (right):

https://codereview.chromium.org/1839743002/diff/40001/gm/convexpolyeffect.cpp...
gm/convexpolyeffect.cpp:183: static const SkScalar kDX = 12.f;
why did this change from 10.f to 12.f?

https://codereview.chromium.org/1839743002/diff/40001/src/gpu/effects/GrConve...
File src/gpu/effects/GrConvexPolyEffect.cpp (right):

https://codereview.chromium.org/1839743002/diff/40001/src/gpu/effects/GrConve...
src/gpu/effects/GrConvexPolyEffect.cpp:8: #include
<effects/GrConstColorProcessor.h>
using <...> here?

[egdaniel, 2016-03-28 21:42:14]

lgtm with a couple questions

[bsalomon, 2016-03-28 21:52:54]

https://codereview.chromium.org/1839743002/diff/40001/gm/convexpolyeffect.cpp
File gm/convexpolyeffect.cpp (right):

https://codereview.chromium.org/1839743002/diff/40001/gm/convexpolyeffect.cpp...
gm/convexpolyeffect.cpp:183: static const SkScalar kDX = 12.f;
On 2016/03/28 21:42:13, egdaniel wrote:
> why did this change from 10.f to 12.f?

The test cases were exactly abutting.. just wanted them visually separated and 2
margin pixels looked better than 1.

https://codereview.chromium.org/1839743002/diff/40001/src/gpu/effects/GrConve...
File src/gpu/effects/GrConvexPolyEffect.cpp (right):

https://codereview.chromium.org/1839743002/diff/40001/src/gpu/effects/GrConve...
src/gpu/effects/GrConvexPolyEffect.cpp:8: #include
<effects/GrConstColorProcessor.h>
On 2016/03/28 21:42:13, egdaniel wrote:
> using <...> here?

Ugh, my IDE inserted this without me realizing it. Will fix.

[bsalomon, 2016-03-28 21:54:53]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-28 21:54:54]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1839743002/#ps60001
(title: "Fix include to use "" instead  of <>")

[commit-bot: I haz the power, 2016-03-28 21:54:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839743002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839743002/60001

[commit-bot: I haz the power, 2016-03-28 22:04:48]

Description was changed from

==========
Fix GrConvexPolyEffect to deal with line paths.

BUG=skia:4727
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix GrConvexPolyEffect to deal with line paths.

BUG=skia:4727
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7888de0db74ac08162c85903a71a48f6d2a3013f
==========

[commit-bot: I haz the power, 2016-03-28 22:04:49]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7888de0db74ac08162c85903a71a48f6d2a3013f