Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183973039: Add version resource to chrome_elf.dll (Closed)

Created:
6 years, 9 months ago by robertshield
Modified:
6 years, 9 months ago
Reviewers:
gab
CC:
chromium-reviews, caitkp+watch_chromium.org, grt (UTC plus 2)
Visibility:
Public.

Description

Add version resource to chrome_elf.dll BUG=349926 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255570

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome_elf/chrome_elf.gyp View 2 chunks +27 lines, -0 lines 2 comments Download
A chrome_elf/chrome_elf.ver View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
robertshield
6 years, 9 months ago (2014-03-06 18:34:40 UTC) #1
gab
Looks similar enough to the code doing this for chrome.exe so lgtm I guess :) ...
6 years, 9 months ago (2014-03-06 18:50:10 UTC) #2
gab
https://codereview.chromium.org/183973039/diff/1/chrome_elf/chrome_elf.gyp File chrome_elf/chrome_elf.gyp (right): https://codereview.chromium.org/183973039/diff/1/chrome_elf/chrome_elf.gyp#newcode10 chrome_elf/chrome_elf.gyp:10: '../build/win_precompile.gypi', unrelated nit but shouldn't we s/../<(DEPTH) ?
6 years, 9 months ago (2014-03-06 18:50:20 UTC) #3
robertshield
https://codereview.chromium.org/183973039/diff/1/chrome_elf/chrome_elf.gyp File chrome_elf/chrome_elf.gyp (right): https://codereview.chromium.org/183973039/diff/1/chrome_elf/chrome_elf.gyp#newcode10 chrome_elf/chrome_elf.gyp:10: '../build/win_precompile.gypi', On 2014/03/06 18:50:21, gab wrote: > unrelated nit ...
6 years, 9 months ago (2014-03-06 20:48:53 UTC) #4
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 9 months ago (2014-03-06 20:48:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/183973039/1
6 years, 9 months ago (2014-03-06 21:19:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 21:35:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 21:35:21 UTC) #8
gab
The CQ bit was checked by gab@chromium.org
6 years, 9 months ago (2014-03-06 21:59:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/183973039/1
6 years, 9 months ago (2014-03-06 22:30:48 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 09:34:23 UTC) #11
Message was sent while issue was closed. 
Change committed as 255570

Powered by Google App Engine
This is Rietveld 408576698