Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 183973037: Cherry-pick Clang upstream r199830 - Handle va_arg on struct types for the le32 target (PNaCl and E… (Closed)

Created:
6 years, 9 months ago by JF
Modified:
6 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-clang.git@master
Visibility:
Public.

Description

Cherry-pick Clang upstream r199830 - Handle va_arg on struct types for the le32 target (PNaCl and Emscripten) Author: mseaborn Date: Wed Jan 22 14:11:01 2014 New Revision: 199830 URL: http://llvm.org/viewvc/llvm-project?rev=199830&view=rev Log: Handle va_arg on struct types for the le32 target (PNaCl and Emscripten) PNaCl and Emscripten can both handle va_arg IR instructions with struct type. Also add a test to cover generating a va_arg IR instruction from va_arg in C on le32 (as already handled by VisitVAArgExpr() in CGExprScalar.cpp), which was not covered by a test before. (This fixes https://code.google.com/p/nativeclient/issues/detail?id=2381) Differential Revision: http://llvm-reviews.chandlerc.com/D2539 R=mseaborn@chromium.org, dschuff@chromium.org, jvoung@chromium.org TEST= ninja clang-check BUG= https://code.google.com/p/nativeclient/issues/detail?id=2381 Committed: c9e1197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M lib/CodeGen/CGExprAgg.cpp View 1 chunk +5 lines, -1 line 0 comments Download
A test/CodeGen/le32-vaarg.c View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
JF
6 years, 9 months ago (2014-03-06 03:56:38 UTC) #1
JF
This patch was asked to be cherry-picked on Twitter (https://twitter.com/take_cheeze/status/440559473938423808). It should only go in ...
6 years, 9 months ago (2014-03-06 03:59:02 UTC) #2
JF
LLVM 3.4 is now in Chrome (as of https://codereview.chromium.org/187673006/), so this cherry-pick can go in ...
6 years, 9 months ago (2014-03-06 18:00:32 UTC) #3
Mark Seaborn
LGTM
6 years, 9 months ago (2014-03-06 18:09:52 UTC) #4
JF
The CQ bit was checked by jfb@chromium.org
6 years, 9 months ago (2014-03-06 18:22:01 UTC) #5
JF
6 years, 9 months ago (2014-03-06 20:42:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as rc9e1197 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698