Remove some SVG API

Remove some SVG API

This code is not in use anymore, mostly because of bindings changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168594

[rwlbuis, 2014-03-05 22:28:19]

Simple cleanup patch

[pdr., 2014-03-05 22:37:59]

On 2014/03/05 22:28:19, rwlbuis wrote:
> Simple cleanup patch

Stupid rietveld and "error: old chunk mismatch" :(

Could you please re-upload this change? Just do "git cl upload" one more time.
Sorry :(

[rwlbuis, 2014-03-05 22:46:30]

On 2014/03/05 22:37:59, pdr wrote:
> On 2014/03/05 22:28:19, rwlbuis wrote:
> > Simple cleanup patch
> 
> Stupid rietveld and "error: old chunk mismatch" :(
> 
> Could you please re-upload this change? Just do "git cl upload" one more time.
> Sorry :(

Done!

[pdr., 2014-03-05 22:59:33]

LGTM with a question

https://codereview.chromium.org/183973036/diff/20001/Source/core/svg/SVGColor...
File Source/core/svg/SVGColor.cpp (left):

https://codereview.chromium.org/183973036/diff/20001/Source/core/svg/SVGColor...
Source/core/svg/SVGColor.cpp:59: void SVGColor::setRGBColor(const String&,
ExceptionState& exceptionState)
This this actually gone? This looks like a user-visible change.

[rwlbuis, 2014-03-05 23:03:31]

On 2014/03/05 22:59:33, pdr wrote:
> LGTM with a question
> 
>
https://codereview.chromium.org/183973036/diff/20001/Source/core/svg/SVGColor...
> File Source/core/svg/SVGColor.cpp (left):
> 
>
https://codereview.chromium.org/183973036/diff/20001/Source/core/svg/SVGColor...
> Source/core/svg/SVGColor.cpp:59: void SVGColor::setRGBColor(const String&,
> ExceptionState& exceptionState)
> This this actually gone? This looks like a user-visible change.

All of the SVGColor idl is gone.

[pdr., 2014-03-05 23:04:15]

On 2014/03/05 23:03:31, rwlbuis wrote:
> On 2014/03/05 22:59:33, pdr wrote:
> > LGTM with a question
> > 
> >
>
https://codereview.chromium.org/183973036/diff/20001/Source/core/svg/SVGColor...
> > File Source/core/svg/SVGColor.cpp (left):
> > 
> >
>
https://codereview.chromium.org/183973036/diff/20001/Source/core/svg/SVGColor...
> > Source/core/svg/SVGColor.cpp:59: void SVGColor::setRGBColor(const String&,
> > ExceptionState& exceptionState)
> > This this actually gone? This looks like a user-visible change.
> 
> All of the SVGColor idl is gone.

Interesting. There's a lot of SVGColor stuff left in the tree. Maybe some
deadcode is hiding in there?

LGTM

[rwlbuis, 2014-03-05 23:15:42]

On 2014/03/05 23:04:15, pdr wrote:
> On 2014/03/05 23:03:31, rwlbuis wrote:
> > On 2014/03/05 22:59:33, pdr wrote:
> > > LGTM with a question
> > > 
> > >
> >
>
https://codereview.chromium.org/183973036/diff/20001/Source/core/svg/SVGColor...
> > > File Source/core/svg/SVGColor.cpp (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/183973036/diff/20001/Source/core/svg/SVGColor...
> > > Source/core/svg/SVGColor.cpp:59: void SVGColor::setRGBColor(const String&,
> > > ExceptionState& exceptionState)
> > > This this actually gone? This looks like a user-visible change.
> > 
> > All of the SVGColor idl is gone.
> 
> Interesting. There's a lot of SVGColor stuff left in the tree. Maybe some
> deadcode is hiding in there?

Yeah I'll look into that.

> LGTM

Thanks! :)

[rwlbuis, 2014-03-05 23:15:58]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-03-05 23:16:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/183973036/20001

[commit-bot: I haz the power, 2014-03-06 08:09:27]

Change committed as 168594