Refactoring of the NetworkPortalDetector.

Refactoring of the NetworkPortalDetector.

Different detection strategies are extracted into individual entities,
which can be switched at run-time. Currently we have only two detection strategies:
* login screen strategy: 3 detection attempts, detection timeout is
  proportional to current attempt number.
* error screen strategy: unlimited number of detection attempts,
  detection timeout is fixed.

BUG=240237
TEST=unit_tests:NetworkPortalDetectorImpl*
R=nkostylev@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255545

[Nikita (slow), 2014-03-05 15:50:47]

As discussed please ask Denis or Pavel review this code.

[ygorshenin1, 2014-03-05 15:53:38]

+ Denis
Denis, could you please review this code?

[Denis Kuznetsov (DE-MUC), 2014-03-05 16:59:09]

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
File chrome/browser/chromeos/net/network_portal_detector_impl.h (right):

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_impl.h:95: void
CancelDetection();
StopDetection() ?

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_impl.h:102: //
CanPerformAttempt() *must* be kept before call to this method.
Maybe reword it to "You should check CanPerformAttempt() before calling this
method".

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_impl.h:214:
PortalDetectorStrategy* strategy_;
I'd prefer if there was one scoped_ptr with current strategy.

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
File chrome/browser/chromeos/net/network_portal_detector_strategy.h (right):

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_strategy.h:27:
base::TimeDelta GetDelayBeforeCurrentAttempt();
GetDelayTillNextAttempt ?

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_strategy.h:28:
base::TimeDelta GetCurrentAttemptTimeout();
comments for methods?

[ygorshenin1, 2014-03-06 11:59:33]

PTAL

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
File chrome/browser/chromeos/net/network_portal_detector_impl.h (right):

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_impl.h:95: void
CancelDetection();
On 2014/03/05 16:59:09, Denis Kuznetsov wrote:
> StopDetection() ?

Done.

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_impl.h:102: //
CanPerformAttempt() *must* be kept before call to this method.
On 2014/03/05 16:59:09, Denis Kuznetsov wrote:
> Maybe reword it to "You should check CanPerformAttempt() before calling this
> method".

Done.

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_impl.h:214:
PortalDetectorStrategy* strategy_;
On 2014/03/05 16:59:09, Denis Kuznetsov wrote:
> I'd prefer if there was one scoped_ptr with current strategy.

Done.

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
File chrome/browser/chromeos/net/network_portal_detector_strategy.h (right):

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_strategy.h:27:
base::TimeDelta GetDelayBeforeCurrentAttempt();
On 2014/03/05 16:59:09, Denis Kuznetsov wrote:
> GetDelayTillNextAttempt ?

Done.

https://codereview.chromium.org/183973029/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_detector_strategy.h:28:
base::TimeDelta GetCurrentAttemptTimeout();
On 2014/03/05 16:59:09, Denis Kuznetsov wrote:
> comments for methods?
> 

Done.

[Denis Kuznetsov (DE-MUC), 2014-03-06 17:51:31]

lgtm

[ygorshenin1, 2014-03-06 18:36:43]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-03-06 18:40:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/183973029/20001

[commit-bot: I haz the power, 2014-03-06 18:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 18:50:38]

Try jobs failed on following builders: mac_chromium_rel

[ygorshenin1, 2014-03-06 19:53:37]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-03-06 19:57:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/183973029/20001

[commit-bot: I haz the power, 2014-03-06 21:04:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/183973029/20001

[commit-bot: I haz the power, 2014-03-06 21:58:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/183973029/20001

[commit-bot: I haz the power, 2014-03-07 08:35:01]

Change committed as 255545