Issue 183973024: Remove __nacl_futex_fini

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183973024: Remove __nacl_futex_fini (Closed)

Created:
6 years, 9 months ago by Sam Clegg

Modified:
6 years, 9 months ago

Reviewers:
Mark Seaborn

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master

Visibility:
Public.

More Reviews

Description

Remove __nacl_futex_fini This allows fuxtex's (and therefore pthreads) to keep working even in _exit() after the atexit handlers have all been run. TEST=toolchains trybots BUG= https://code.google.com/p/chromium/issues/detail?id=337584 R=mseaborn@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=6b56700

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	elf/dl-fini.c	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	sysdeps/nacl/futex_emulation.c	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

Committed patchset #1 manually as r6b56700 (presubmit successful).

6 years, 9 months ago (2014-03-04 20:46:42 UTC) #3

Mark Seaborn

Should this change have "BUG= https://code.google.com/p/chromium/issues/detail?id=337584"?

6 years, 9 months ago (2014-03-04 21:55:15 UTC) #4

Sam Clegg

6 years, 9 months ago (2014-03-04 21:57:12 UTC) #5

Message was sent while issue was closed.

On 2014/03/04 21:55:15, Mark Seaborn wrote:
> Should this change have "BUG=
> https://code.google.com/p/chromium/issues/detail?id=337584%22?

Yes.  I've updated the CL description, post-submit.

Expand Messages | Collapse Messages