Issue 183973023: Always reset the animated property for CSS-type SVG animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183973023: Always reset the animated property for CSS-type SVG animation (Closed)

Created:
6 years, 9 months ago by fs

Modified:
6 years, 9 months ago

Reviewers:
pdr., f(malita), Stephen Chennney, rwlbuis

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Always reset the animated property for CSS-type SVG animation When resetting the animated property value for animations that is applied as a CSS property always create a new property, or additive animations will accumulate incorrectly to the underlying value. BUG=349052 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168475

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -2 lines)			Patch
A	LayoutTests/svg/animations/additive-from-to-fill-animation.html	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/animations/additive-from-to-fill-animation-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGAnimateElement.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/183973023/1

6 years, 9 months ago (2014-03-04 23:32:47 UTC) #4

Message was sent while issue was closed.

Change committed as 168475

Expand Messages | Collapse Messages