content/common/media/media_track_lifetime_metrics_messages.h - Issue 183973021: Add metrics to track the duration of tracks received over a PeerConnection.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/media/media_track_lifetime_metrics_messages.h

Issue 183973021: Add metrics to track the duration of tracks received over a PeerConnection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Now logging in browser process. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/renderer_host/media/media_track_lifetime_metrics_host.cc ('K') | « content/common/content_message_generator.h ('k') | content/content_browser.gypi » ('j') | content/content_browser.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/values.h"

	6 #include "content/common/content_export.h"

	7 #include "ipc/ipc_message_macros.h"

	8

	9 #undef IPC_MESSAGE_EXPORT

	10 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT

	11 #define IPC_MESSAGE_START MediaTrackLifetimeMetricsHostMsgStart

	12

	13 // Messages sent to MediaTrackLifetimeMetricsHost.

	14 IPC_MESSAGE_CONTROL2(MediaTrackLifetimeMetrics_AddTrack,

	15 std::string /* id */,

	16 bool /* is_audio */)
	perkj_chrome 2014/03/11 08:05:21 local and remote tracks ? local and remote tracks ? Jói 2014/03/11 17:36:33 Makes sense to add that right away to avoid an add Show quoted text On 2014/03/11 08:05:21, perkj wrote: > local and remote tracks ? Makes sense to add that right away to avoid an additional roundtrip later through security review. Added.
	17 IPC_MESSAGE_CONTROL1(MediaTrackLifetimeMetrics_RemoveTrack,

	18 std::string /* id */)

OLD	NEW