Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 183973012: Add NeedsManualRebaseline suppressions for vs2013 switchover (Closed)

Created:
6 years, 9 months ago by Dirk Pranke
Modified:
6 years, 9 months ago
Reviewers:
scottmg
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add NeedsManualRebaseline suppressions for vs2013 switchover This change suppresses the remaining failures resulting from the switch to Visual Studio 2013 until scottmg or I can go through and rebaseline them. There's probably a couple local failures from my machine that shouldn't be rebaselined, and a couple of legit bugs as well, which is why I don't want to use 'NeedsRebaseline' for the bot to automatically deal with this. TBR=scottmg@chromium.org BUG=309197 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -2 lines) Patch
LayoutTests/TestExpectations View 3 chunks +260 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
6 years, 9 months ago (2014-03-02 00:21:10 UTC) #1
Dirk Pranke
Committed patchset #1 manually as r168250 (presubmit successful).
6 years, 9 months ago (2014-03-02 00:22:52 UTC) #2
scottmg
6 years, 9 months ago (2014-03-02 02:41:05 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698