Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1839713002: [Telemetry] Update the code that detect windows version to use CurrentMajorVersionNumber (Reland) (Closed)

Created:
4 years, 8 months ago by nednguyen
Modified:
4 years, 8 months ago
Reviewers:
brucedawson
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Update the code that detect windows version to use CurrentMajorVersionNumber (Reland) Since Windows 8, platform.uname()'s third field starts with 6.2, hence to detect Windows 10, we have to use CurrentMajorVersionNumber from registry. This is a reland of https://codereview.chromium.org/1830253003/ Fix is added in patch 2. BUG=chromium:596640 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/02c0e106d409492a00606015e02a566943708bc8

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M telemetry/telemetry/core/os_version.py View 1 chunk +1 line, -0 lines 0 comments Download
M telemetry/telemetry/internal/platform/win_platform_backend.py View 1 3 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nednguyen
4 years, 8 months ago (2016-03-28 18:17:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839713002/20001
4 years, 8 months ago (2016-03-28 18:18:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-28 18:54:00 UTC) #7
brucedawson
lgtm
4 years, 8 months ago (2016-03-29 00:53:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839713002/20001
4 years, 8 months ago (2016-03-29 01:18:31 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 01:20:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698