Issue 1839663003: More fixes to summary linking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1839663003: More fixes to summary linking. (Closed)

Created:
4 years, 8 months ago by Paul Berry

Modified:
4 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More fixes to summary linking. This CL makes the following fixes: - Handles the case where a constant makes an explicit reference to a type. - Handles references to top level names defined in imported libraries. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/03c401f3fd865e730c798cc80c2c78d5a6b646d4

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -9 lines)			Patch
M	pkg/analyzer/lib/src/summary/link.dart	View		4 chunks	+22 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summarize_ast_test.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_common.dart	View	1	3 chunks	+163 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 8 months ago (2016-03-28 19:22:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
03c401f3fd865e730c798cc80c2c78d5a6b646d4 (presubmit successful).