Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1839663002: S390: Fix Register conflict in CEntryStub (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix Register conflict in CEntryStub when needs_return_buffer == true and result_size() > 2, the 3rd return value is placed in r4 register. But when debug code is emited, it uses r4 register for checking exceptions, which corrupts the 3rd return value. R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/d65c8cbf2d90798303f1293e0d6d4eab8ea2cfee Cr-Commit-Position: refs/heads/master@{#35084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/s390/code-stubs-s390.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839663002/1
4 years, 8 months ago (2016-03-28 16:54:49 UTC) #2
john.yan
PTAL
4 years, 8 months ago (2016-03-28 16:54:50 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-28 17:18:01 UTC) #5
JoranSiu
On 2016/03/28 17:18:01, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-03-28 17:27:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839663002/1
4 years, 8 months ago (2016-03-28 17:31:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 17:35:33 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 17:37:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d65c8cbf2d90798303f1293e0d6d4eab8ea2cfee
Cr-Commit-Position: refs/heads/master@{#35084}

Powered by Google App Engine
This is Rietveld 408576698